Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-introduce sudo to setup polkadot shell (DO NOT MERGE) #254

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Jan 29, 2024

** NEVER MERGE **
keep for reference purposes
meant to upgrade shell v4 to integritee-runtime v43

tested with chopsticks:
npx @acala-network/chopsticks@0.9.7 --config ~/chopsticks/configs/integritee-polkadot.yml --block 2371405 --wasm-override ./target/release/wbuild/integritee-runtime/integritee_runtime.compact.compressed.wasm

  • pallet storage versions are not initialized 👎
  • sudo key stays same and can act 👍
  • other accounts can transfer 👍

resulting pallet storage versions, queried with chopsticks:

  • balances: 1
  • bounties: 4
  • council: 4
  • democracy: 1
  • dmpQueue: 2
  • multisig: 1
  • polkadotXcm: 1
  • preimage: 1
  • scheduler: 4
  • technicalCommittee: 4
  • teerex: 2
  • xcmpQueue: 3

try-runtime:

try-runtime --runtime ./target/release/wbuild/integritee-runtime/integritee_runtime.compact.compressed.wasm on-runtime-upgrade --checks=pre-and-post --disable-spec-version-check --disable-idempotency-checks live --uri wss://polkadot.api.integritee.network:443

build with srtool (as this branch will not be released):

srtool build -p integritee-runtime --runtime-dir polkadot-parachains/integritee-runtime/ --root

@brenzi
Copy link
Collaborator Author

brenzi commented Jan 29, 2024

built 9e91d5e with srtool:

 Version          : integritee-parachain-43 (integritee-full-1.tx6.au2)
 Metadata         : V14
 Size             : 1.08 MB (1136094 bytes)
 Compression      : 77.82%
 setCode          : 0xec2ba5557e74537e73ef13684b43b542730b23137d9a47d46e51d2563f20c069
 authorizeUpgrade : 0xdc564b2306c6a9e0cc90c5e5d05f34a247d49c2b83a241b83f0237611c112cf0
 IPFS             : QmTRtfbhfG8zXKirB3XvLphxv9SDSTxFr1Fz5LJcSoyaRh
 BLAKE2_256       : 0x247612e64cffde6feb21755a586ec01a2347a8bc9e53a49e05a3e2f802d2ce08
 Wasm             : polkadot-parachains/integritee-runtime//target/srtool/release/wbuild/integritee-runtime/integritee_runtime.compact.compressed.wasm

@brenzi brenzi requested a review from clangenb January 29, 2024 16:10
@brenzi
Copy link
Collaborator Author

brenzi commented Jan 29, 2024

@clangenb this is the runtime I would use to wake up our polkadot shell parachain. agree?

notes:

  • migration and post-migration functionality tested with chopsticks, incl sudo
  • check-migrations CI expected to fail as this is not intended to go to kusama

@brenzi brenzi changed the title re-introduce sudo to setup polkadot shell re-introduce sudo to setup polkadot shell (DO NOT MERGE) Jan 29, 2024
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the sudo pallet index, I think this is fine.

Comment on lines +262 to +264
// this is necessary because migrations from v0 to v3 are no longer available in the scheduler
// pallet code and migrating is only possible from v3. The strategy here is to empty the agenda
// (has been empty since genesis)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste error in all cases, not that we really care though.

@brenzi brenzi mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants