Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot v1.0.0 #248

Merged
merged 17 commits into from
Jan 23, 2024
Merged

Polkadot v1.0.0 #248

merged 17 commits into from
Jan 23, 2024

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Jan 22, 2024

closes #200
closes #246

this concludes all missed migrations for parity pallets and is expected to fix our XCM issues

@brenzi brenzi marked this pull request as ready for review January 23, 2024 09:14
@brenzi brenzi requested a review from clangenb January 23, 2024 09:20
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me except for the typo!

@brenzi
Copy link
Collaborator Author

brenzi commented Jan 23, 2024

migrations work against rococo which is already at V41. I suggest to postpone merge until mainnet is on v41 and then re-trigger the migration check

@brenzi
Copy link
Collaborator Author

brenzi commented Jan 23, 2024

In this case I don't care for idempotency. try-runtime was a success at first run

@brenzi brenzi merged commit 4e5e23d into master Jan 23, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check missing migrations in the past Switch to stable rust tool-chain when possible
2 participants