Skip to content

chore: Allow numpy >= 2.0.0 #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Allow numpy >= 2.0.0 #479

wants to merge 1 commit into from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Apr 18, 2025

A large e2e run with forced numpy 2.0+ suggests that the library is compatible with numpy 2.x series.

Also, removed numpy dependency from requirements-dev.txt because it's already listed in requirements.txt.

See: https://github.com/instructlab/training/actions/runs/14539292904

Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com

@booxter booxter marked this pull request as draft April 18, 2025 17:19
@mergify mergify bot added CI/CD Affects CI/CD configuration ci-failure dependencies Pull requests that update a dependency file labels Apr 18, 2025
Copy link

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

Copy link

e2e workflow succeeded on this PR: View run, congrats!

@booxter booxter force-pushed the ihrachyshka-numpy branch from a9bae5c to 5b27dd6 Compare April 18, 2025 22:05
@booxter booxter changed the title Test: bump numpy to 2+ chore: Allow numpy >= 2.0.0 Apr 18, 2025
@booxter booxter marked this pull request as ready for review April 18, 2025 22:05
@booxter booxter force-pushed the ihrachyshka-numpy branch from 5b27dd6 to 4612bca Compare April 19, 2025 01:14
@mergify mergify bot added ci-failure and removed ci-failure labels Apr 19, 2025
@RobotSail
Copy link
Member

@booxter We use numpy in a few critical points like the collator function in the dataloader as well as the data processing logic when converting from messages into raw input IDs for the model to consume. This is a PR where we'd need to run training and validate that the loss curve from your changes produces the same loss curve as what's in the main branch.

@booxter
Copy link
Contributor Author

booxter commented Apr 28, 2025

Fair enough. We'll need to automate validation for patches like this one (also refactors etc.) I don't feel we should continue with human assessments (or at the very least artifacts - charts etc. - needed for such assessment should be generated and posted in comments.) I will mark this as a draft and report an issue to implement the necessary automation.

@booxter booxter marked this pull request as draft April 28, 2025 20:15
@RobotSail
Copy link
Member

@booxter Yes, we have a script to do this already but I think it broke and I haven't had time to look into it. If you can fix it then that would be a huge contribution which would automate most of the testing we do manually today. You can find it here: https://github.com/instructlab/training/blob/main/scripts/create-loss-graph.py

And then the actual CI code to call it can be found here:

python training/scripts/create-loss-graph.py \

@booxter
Copy link
Contributor Author

booxter commented May 1, 2025

@Mergifyio rebase

A large e2e run with forced numpy 2.0+ suggests that the library is
compatible with numpy 2.x series.

Also, removed `numpy` dependency from requirements-dev.txt because it's
already listed in requirements.txt.

See: https://github.com/instructlab/training/actions/runs/14539292904

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Copy link
Contributor

mergify bot commented May 1, 2025

rebase

✅ Branch has been successfully rebased

@booxter booxter force-pushed the ihrachyshka-numpy branch from 4612bca to 37a41c3 Compare May 1, 2025 14:22
@mergify mergify bot removed the ci-failure label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants