feat: update readme with json logger details #47
Conversation
marl_eval/json_tools/json_utils.py
Outdated
| except zipfile.BadZipFile: | ||
| # If the file is not zipped continue to the next file | ||
| # as it is already downloaded. | ||
| continue |
There was a problem hiding this comment.
Don't quite follow why we wouldn't also throw this as an error?
There was a problem hiding this comment.
This just assumes the file doesn't have to be unzipped. All files are already downloaded before attempting to unzip them, so we just continue. The zipfile.BadZipFile is just a bit misleading.
There was a problem hiding this comment.
Ah then can we change the docs: saying its already unzipped instead of already downloaded.
Just checking that it's placed in the same directory as the files that are unzipped?
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
marl_eval/json_tools/json_utils.py
Outdated
| except zipfile.BadZipFile: | ||
| # If the file is not zipped continue to the next file | ||
| # as it is already downloaded. | ||
| continue |
There was a problem hiding this comment.
Ah then can we change the docs: saying its already unzipped instead of already downloaded.
Just checking that it's placed in the same directory as the files that are unzipped?
Co-authored-by: Sasha <reallysasha@gmail.com>
What?
Add information about the JSON logger to the readme.
Extra
marl_eval/json_tools/__init__.py