Feat/add json logger #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sash-a
requested changes
Feb 23, 2024
marl_eval/json_tools/json_logger.py
Outdated
| environment_name: str, | ||
| seed: int, | ||
| ): | ||
| """Initialises the JsonWriter and creates the file if it doesn't exist.""" |
There was a problem hiding this comment.
Suggested change
| """Initialises the JsonWriter and creates the file if it doesn't exist.""" | |
| """Initialises the JsonLogger and create the file if it doesn't exist.""" |
There was a problem hiding this comment.
Wrote it slightly differently to your suggestion.
| self.run_data[step_str] = step_metrics | ||
|
|
||
| with open(self.file_path, "w") as f: | ||
| json.dump(self.data, f, indent=4) |
There was a problem hiding this comment.
if we reduced the indent to 2 here it would save quite a lot of space 🤔
There was a problem hiding this comment.
True. We've just used 4 as a default in the past.
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
sash-a
previously approved these changes
Feb 23, 2024
Co-authored-by: Sasha <reallysasha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a json logger to marl-eval to enable easy logging according to the protocol in the correct json format.