Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use released version of lzstring #10

Merged
merged 1 commit into from
Oct 25, 2024
Merged

use released version of lzstring #10

merged 1 commit into from
Oct 25, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Oct 22, 2024

  • lzstring got released so there is no need for a Remotes field
  • small tests enhancements
  • add test about respecting the order

@pawelru pawelru added the core label Oct 22, 2024
@pawelru pawelru enabled auto-merge (squash) October 22, 2024 08:11
Copy link
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/parse_url.R                   12       0  100.00%
R/tag_examplesShinylive.R       72       0  100.00%
TOTAL                           84       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: aa8fe8a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

 1 files   2 suites   0s ⏱️
15 tests 15 ✅ 0 💤 0 ❌
54 runs  54 ✅ 0 💤 0 ❌

Results for commit aa8fe8a.

Copy link
Contributor

Unit Tests Summary

 1 files   2 suites   0s ⏱️
15 tests 13 ✅ 2 💤 0 ❌
52 runs  50 ✅ 2 💤 0 ❌

Results for commit aa8fe8a.

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tag_examplesShinylive 💀 $0.02$ $-0.02$ examplesShinylive_tag_don_t_use_previous_example_code
tag_examplesShinylive 👶 $+0.02$ examplesShinylive_tag_on_default_use_only_next_example_code
tag_examplesShinylive 👶 $+0.01$ examplesShinylive_tag_respect_order_of_tags_after_examples
tag_examplesShinylive 👶 $+0.01$ examplesShinylive_tag_respect_order_of_tags_before_examples

Results for commit fbceb79

♻️ This comment has been updated with latest results.

@pawelru pawelru mentioned this pull request Oct 22, 2024
32 tasks
@m7pr m7pr self-assigned this Oct 25, 2024
@pawelru pawelru merged commit be1f1b9 into main Oct 25, 2024
28 of 29 checks passed
@pawelru pawelru deleted the rm_remotes branch October 25, 2024 09:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants