Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the package #1

Merged
merged 22 commits into from
Sep 19, 2024
Merged

Initialize the package #1

merged 22 commits into from
Sep 19, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Aug 20, 2024

No description provided.

@pawelru pawelru added the core label Aug 20, 2024
Copy link
Contributor

github-actions bot commented Aug 20, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/parse_url.R                    9       0  100.00%
R/tag_examplesShinylive.R       72       0  100.00%
TOTAL                           81       0  100.00%

Results for commit: 0b2a818

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 20, 2024

Unit Tests Summary

 1 files   2 suites   0s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
50 runs  50 ✅ 0 💤 0 ❌

Results for commit 0b2a818.

♻️ This comment has been updated with latest results.

R/tag_examplesShinylive.R Outdated Show resolved Hide resolved
R/tag_examplesShinylive.R Outdated Show resolved Hide resolved
@gogonzo
Copy link

gogonzo commented Aug 22, 2024

How does it work? Do I understand correctly that at https://shinylive.io/r/app/ there is simple server which decodes an URI code= parameter and returns a webR app? Looks almost serverless, except a simple call to the shinylive

@pawelru
Copy link
Contributor Author

pawelru commented Aug 26, 2024

How does it work? Do I understand correctly that at https://shinylive.io/r/app/ there is simple server which decodes an URI code= parameter and returns a webR app? Looks almost serverless, except a simple call to the shinylive

That's right. It's quite simple. That's why I thought we can easily integrate it to the docs

R/tag_examplesShinylive.R Show resolved Hide resolved
R/tag_examplesShinylive.R Show resolved Hide resolved
R/tag_examplesShinylive.R Outdated Show resolved Hide resolved
R/tag_examplesShinylive.R Show resolved Hide resolved
@donyunardi
Copy link

Forgot to mention that I can't pass the R CMD check locally

image

However, the CI able to run the check successfully.
Is it the version of my tidy cli?

@pawelru
Copy link
Contributor Author

pawelru commented Sep 18, 2024

Forgot to mention that I can't pass the R CMD check locally

I'm a little bit puzzled by what tidy returns. It looks like yours does not like allowfullscreen and mine does not like allow="fullscreen". I think I'm going to remove it completely to limit this dependency. If really needed (which I have doubts) we can bring this back

Copy link

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I also used this material from roxygen2 to understand what's going on with the code:
https://roxygen2.r-lib.org/articles/extending.html

@pawelru pawelru merged commit 00060a9 into main Sep 19, 2024
30 checks passed
@pawelru pawelru deleted the init branch September 19, 2024 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants