Fixed pagenation #810
Merged
Fixed pagenation #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inconsistent variable name resulted in pagenation not working at all.
dbarnett
approved these changes
Nov 5, 2024
|
Weird that this didn't come up in CI checks. |
|
Agreed, it surprised me the wrong variable name wouldn't have failed harder, but for static checks no variable was quite unused or undefined, and for runtime tests the problem behavior was just a bit too subtle to have caught without having some better tests specifically covering pagination behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inconsistent variable name resulted in pagenation not working at all. L344 uses the variable name
page_tokennotpageToken