Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo fixes #75

Merged
merged 18 commits into from
Jan 27, 2025
Merged

Demo fixes #75

merged 18 commits into from
Jan 27, 2025

Conversation

j-mueller
Copy link
Collaborator

@j-mueller j-mueller commented Jan 23, 2025

  • Change "account" to "address" everywhere
  • Change the users to Alice and Bob
  • Add an override flag to the transfer endpoint. This lets you deliberately submit a failing transaction if the sender is blacklisted (for demonstration purposes only -- the tx will consume the collateral input!)
  • Use preview.cexplorer.io instead of cardanoscan - this seems to display new transactions much faster
  • Fix an issue with the link to recently submitted transaction. The link actually pointed to the transaction that produced one of the new transaction's inputs. Now it's pointing to the correct tx id.
  • Use signAndSentTx in the mint tx function
  • Show Ada balance in addition to WST balance

@j-mueller
Copy link
Collaborator Author

image

Copy link
Collaborator

@choener choener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo should work fine. However, I have two actions that I can't get to work:

  • Mint Authority / Send / 1 / yields bad request and permanent "Transaction processing" ?
  • I seem to be unable to "force send failing transaction" to frozen Alice from Bob, at least I don't loose Ada (collateral)

I am still approving, since this wouldn't prevent the demo working, but maybe take a look. Could also be I did something wrong?

The following are concerns:

  • Reloading any pane gives file-not-found (missing .html extension)
  • Alice / Bob should have their full addresses on the pane, not hidden behind the receive button
  • The UI does not provide good feedback on errors, especially when no data can be received. I had a blockfrost api key pointing to the wrong net and didn't get any feedback, apart from console errors.
  • I have successfully unfrozen Alice, but it still shows frozen? Reload fixes this, but missing route (.html suffix) makes it annoying.
  • The mint authority / addresses tab is not always updating for me (i.e. Alice shown as frozen, while I have the "successfully unfrozen" tx message on screen as well.

@j-mueller
Copy link
Collaborator Author

I seem to be unable to "force send failing transaction" to frozen Alice from Bob, at least I don't loose Ada (collateral)

"force send" is for the frozen wallet (Alice) - you can always send tokens to a wallet that has been frozen. The check against the blacklist is only done for the sender..

@j-mueller
Copy link
Collaborator Author

Mint Authority / Send / 1 / yields bad request and permanent "Transaction processing" ?

I need to look into that, can't think of a reason for why it shouldn't work with exactly 1 token

@choener
Copy link
Collaborator

choener commented Jan 27, 2025

I seem to be unable to "force send failing transaction" to frozen Alice from Bob, at least I don't loose Ada (collateral)

"force send" is for the frozen wallet (Alice) - you can always send tokens to a wallet that has been frozen. The check against the blacklist is only done for the sender..

If Alice's account is frozen, then I can not send WST to Alice (from Bob). Just checked.

From Alice's side, the behaviour is as expected: if frozen, I have to force the TX. The TX then is successfully put on the net, but no WST are transferred.

@j-mueller j-mueller merged commit 0652f29 into main Jan 27, 2025
5 checks passed
@j-mueller j-mueller deleted the demo-fixes branch January 27, 2025 13:56
@choener
Copy link
Collaborator

choener commented Jan 27, 2025

Mint Authority / Send / 1 / yields bad request and permanent "Transaction processing" ?

I need to look into that, can't think of a reason for why it shouldn't work with exactly 1 token

It also fails with 2, and 10 WST. Probably also with all other values. The mint authority can mint to anybody, but not send to any address, including itself.

The address is also not frozen, or at least I can not unfreeze it. Would have been funny, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants