Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mithril dev blog review #2302

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

oduameh
Copy link
Collaborator

@oduameh oduameh commented Feb 12, 2025

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@oduameh oduameh marked this pull request as draft February 12, 2025 12:49
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oduameh thansk for the PR!

I have made a few comments below.
Also, I see that your commits are not signed which will prevent the merging of the PR.

@olgahryniuk
Copy link
Collaborator

Thank you @jpraynaud! I committed several minor edits directly so that I could see the whole piece. Hope that's okay.
@oduameh, please also address JP's comments above.

@oduameh oduameh marked this pull request as ready for review February 13, 2025 11:34
@jpraynaud
Copy link
Member

HI @oduameh can you sign your commits so that we can merge the PR?

@oduameh
Copy link
Collaborator Author

oduameh commented Feb 14, 2025

HI @oduameh can you sign your commits so that we can merge the PR?

Hi @jpraynaud I this is now done apologies for the delay

@jpraynaud
Copy link
Member

HI @oduameh can you sign your commits so that we can merge the PR?

Hi @jpraynaud I this is now done apologies for the delay

@oduameh some commits were still not signed, but I fixed the problem.
In the future, could you create new PRs directly from the main repository instead of your fork as you have write rights?

@jpraynaud jpraynaud merged commit 33d0727 into input-output-hk:main Feb 14, 2025
36 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants