-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mithril dev blog review #2302
Mithril dev blog review #2302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oduameh thansk for the PR!
I have made a few comments below.
Also, I see that your commits are not signed which will prevent the merging of the PR.
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md
Outdated
Show resolved
Hide resolved
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md
Outdated
Show resolved
Hide resolved
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md
Outdated
Show resolved
Hide resolved
Thank you @jpraynaud! I committed several minor edits directly so that I could see the whole piece. Hope that's okay. |
HI @oduameh can you sign your commits so that we can merge the PR? |
8376991
to
47a29a8
Compare
Hi @jpraynaud I this is now done apologies for the delay |
6d50cc0
to
011bd56
Compare
@oduameh some commits were still not signed, but I fixed the problem. |
Content
This PR includes...
Pre-submit checklist
Comments
Issue(s)
Relates to #YYY or Closes #YYY