-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce e2e flakiness by changing protocol parameters #2301
Merged
sfauvel
merged 4 commits into
main
from
sfa/2222/reduce_flakiness_by_changing_protocol_parameters
Feb 12, 2025
Merged
Reduce e2e flakiness by changing protocol parameters #2301
sfauvel
merged 4 commits into
main
from
sfa/2222/reduce_flakiness_by_changing_protocol_parameters
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca31781
to
1799104
Compare
jpraynaud
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
dlachaume
approved these changes
Feb 12, 2025
Alenar
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bfca3a4
to
ca72570
Compare
* mithril-end-to-end from `0.4.68` to `0.4.69`
ca72570
to
22ba641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Change protocol parameters to reduce e2e test flakiness.
We decrease the
k
parameter of the protocol to 145 to avoid an epoch gap due to a too low number of signatures (less than 150).This PR also print the last aggregator error in the console to help investigation when tests fail.
Example of the error shown in log when test fail
Pre-submit checklist
Issue(s)
Relates to #2222