Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-3985 - Show initial time for counterexamples in a human readable way #57

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

palas
Copy link
Collaborator

@palas palas commented Nov 16, 2023

This PR fixes a legacy vestige that caused the initial time of a counter example produced by the static analysis to be shown as a slot, even though it was an amount of milliseconds. So this PR changes the type names that referred to slots and displays the value as a date and a time.

It also updates the README.md that had one of the commands spelled wrong, and adds the scriv command to the nix development shell.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@palas palas added the bug Something isn't working label Nov 16, 2023
@palas palas requested a review from hrajchert November 16, 2023 01:27
@palas palas self-assigned this Nov 16, 2023
Copy link
Collaborator

@hrajchert hrajchert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I got this error while trying the static analysis... Not sure if related

Screenshot 2023-11-17 at 17 10 48

...Failure: An error occurred while decoding a JSON value: Under 'Response': At object key 'result': Under 'Result': Under 'CounterExample': No value was found.

@palas
Copy link
Collaborator Author

palas commented Nov 20, 2023

The code looks good, but I got this error while trying the static analysis... Not sure if related

Screenshot 2023-11-17 at 17 10 48

...Failure: An error occurred while decoding a JSON value: Under 'Response': At object key 'result': Under 'Result': Under 'CounterExample': No value was found.

I cannot reproduce it. Have you run generate-purescript and the other commands in the README.md?

@palas palas requested a review from hrajchert November 20, 2023 10:55
@hrajchert hrajchert merged commit 177072c into main Nov 21, 2023
5 checks passed
@hrajchert hrajchert deleted the PLT-3985 branch November 21, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants