Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-8331 - Add ability to jump into blockly when loading contract from URL #54

Merged
merged 1 commit into from
Oct 31, 2023
Merged

PLT-8331 - Add ability to jump into blockly when loading contract from URL #54

merged 1 commit into from
Oct 31, 2023

Conversation

paluh
Copy link
Collaborator

@paluh paluh commented Oct 28, 2023

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@paluh paluh force-pushed the switch-to-blockly-param branch from f670783 to 2d539e0 Compare October 28, 2023 14:28
@paluh paluh force-pushed the switch-to-blockly-param branch from 2d539e0 to 283c731 Compare October 28, 2023 14:36
@paluh paluh requested a review from palas October 28, 2023 14:37
palas
palas approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it but it looks good

@palas palas changed the title Add ability to jump into blockly when loading contract from URL PLT-8331 - Add ability to jump into blockly when loading contract from URL Oct 30, 2023
@paluh paluh merged commit 4000df5 into main Oct 31, 2023
5 checks passed
@paluh paluh deleted the switch-to-blockly-param branch October 31, 2023 08:16
@hrajchert
Copy link
Collaborator

Just noted that this breaks previous behaviour, if you don't define "marlowe-view" as a parameter the link is invalid and you are redirected to the home page. It would be better to assume editor as default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palas palas palas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paluh @hrajchert @palas