Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crash screen #1613

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: crash screen #1613

wants to merge 3 commits into from

Conversation

mkazlauskas
Copy link
Member

@mkazlauskas mkazlauskas commented Dec 20, 2024

Checklist

  • JIRA - <LW-11945>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Add crash screen

Screenshots

unhandled-sw-error-tab-view.mov
unhandled-sw-error.mov
unrecoverable-on-load.mov

disregard the red label in video below, it's wrong this is for loading the popup when wallet runs into a recoverable provider error on load

recoverable-on-load.mov

@mkazlauskas mkazlauskas requested a review from a team as a code owner December 20, 2024 12:45
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Dec 20, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ❌ test report for 2c885728

passed failed skipped flaky total result
Total 31 2 4 0 37

@mchappell mchappell self-requested a review December 20, 2024 13:08
Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reload icon present when not in developer mode?

@mkazlauskas
Copy link
Member Author

mkazlauskas commented Dec 21, 2024

Is the reload icon present when not in developer mode?

Yes, it works the same do you mean in chrome://extensions? No, it's only present for unpacked extensions and only in dev mode. We don't need users to click it. The 'Reload extension' button within Lace does it. When you click it, all views (tab/popup) will be closed and user will see the last/previous tab. User has to open Lace again manually.

service worker crashes might cause infinite loader

show button to reload extension on:
- unhandled errors in service worker
- unhandled promise rejections in service worker
- any error in BaseWallet observables
@mkazlauskas mkazlauskas force-pushed the feat/lw-11945-crash-screen branch from 20e57a0 to 2c88572 Compare December 22, 2024 10:39
@mkazlauskas mkazlauskas marked this pull request as draft December 22, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants