-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: crash screen #1613
base: main
Are you sure you want to change the base?
feat: crash screen #1613
Conversation
Allure Report
processReports: ❌ test report for 2c885728
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the reload icon present when not in developer mode?
|
service worker crashes might cause infinite loader show button to reload extension on: - unhandled errors in service worker - unhandled promise rejections in service worker - any error in BaseWallet observables
20e57a0
to
2c88572
Compare
Quality Gate passedIssues Measures |
Checklist
Proposed solution
Add crash screen
Screenshots
unhandled-sw-error-tab-view.mov
unhandled-sw-error.mov
unrecoverable-on-load.mov
disregard the red label in video below, it's wrong this is for loading the popup when wallet runs into a recoverable provider error on load
recoverable-on-load.mov