fix: LW-10549 add missing onboarding and multiwallet posthog events, improve type-safety #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
smokeTests: ✅ test report for 769f294a
|
|
|
||
| export type SendOnboardingAnalyticsEvent = ( | ||
| postHogAction: PostHogAction, | ||
| postHogAction: string, |
There was a problem hiding this comment.
Wouldnt this lower the safety?
There was a problem hiding this comment.
This file is dead. It is old onboarding and I have it removed on a different branch.
There was a problem hiding this comment.
More context: as you can see this PR is based on the codebase unification PR where on ording implementation was swapped with the adjusted multi wallet implementation and all the old code resides there without being used including this file.
shawnbusuttil
approved these changes
May 16, 2024
szymonmaslowski
force-pushed
the
feat/LW-10194-unify-multiwallet-and-onboarding-codebases
branch
from
d2009df to
bc54849
Compare
szymonmaslowski
force-pushed
the
feat/LW-10549-add-wallet-added-events
branch
from
e532b7d to
92fe71e
Compare
oldGreg5
approved these changes
May 20, 2024
Base automatically changed from
feat/LW-10194-unify-multiwallet-and-onboarding-codebases
to
main
May 20, 2024 17:20
szymonmaslowski
force-pushed
the
feat/LW-10549-add-wallet-added-events
branch
from
92fe71e to
23b3f3f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Extracted onboarding and multi-wallet posthog events from the
PosthogActionenum to be separate entities. Improved type safety around those events.Testing
Onboarding and multi-wallet flows send identical posthog events (same number of events, same time of sending) - same event texts except for the prefix which is either
onboardingormultiwalet.