[LW-10451] Address book name broken on address input #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-barros
requested review from
DominikGuzei,
renanvalentin,
VanessaPC and
tomislavhoracek
Allure Report
smokeTests: ✅ test report for 34fea0d9
|
lucas-barros
force-pushed
the
fix/lw-10451-address-book-name-broken-on-address-input
branch
from
c63926d to
e1f00da
Compare
|
@lucas-barros In the core storybook i can see that the address book name doesn't look right (font color) on dark theme: |
@DominikGuzei that was due to switching from story with global theme to one with local theme. Fixed here: 75de21c. |
lucas-barros
force-pushed
the
fix/lw-10451-address-book-name-broken-on-address-input
branch
from
c216cb8 to
6ae08fc
Compare
renanvalentin
approved these changes
May 15, 2024
ljagiela
approved these changes
May 17, 2024
lucas-barros
force-pushed
the
fix/lw-10451-address-book-name-broken-on-address-input
branch
from
6ae08fc to
34fea0d
Compare
|
pczeglik-iohk
deleted the
fix/lw-10451-address-book-name-broken-on-address-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Testing
Create an address book entry with a white space such as "My address" and verify that the name is displayed correctly in send flow.
Screenshots