fix(extension): check for empty assets and next bundle coin id on add… #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vetalcore
commented
May 13, 2024
| @@ -54,7 +54,7 @@ export const Form = ({ | |||
|
|
|||
| const { setNewOutput } = useOutputs(); | |||
|
|
|||
| const isEmptyAssets = assetBalances?.size === 0; | |||
There was a problem hiding this comment.
in case assetBalances is undefined it won't be === 0
@mchappell @tommayeliog please correct me if i'm missing something.
There was a problem hiding this comment.
you've not missed anything, that's the correct check to implement 🚀
Comment on lines
-103
to
-105
| const bundleDisabled = spendableCoin | ||
| ? !getNextBundleCoinId(spendableCoin?.toString(), assetBalances, tokensUsed, assets, cardanoCoin)?.length | ||
| : false; |
There was a problem hiding this comment.
was it intended to set bundleDisabled to false if spendableCoin is falsy?
@mchappell @tommayeliog please correct me if i'm missing something.
Allure Report
smokeTests: ✅ test report for d1c89ea3
|
wklos-iohk
approved these changes
May 14, 2024
vetalcore
deleted the
fix/lw-7143-disable-add-bundle-if-no-assets-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… bundle
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes