-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/lw 10534 translation package #1154
Conversation
07a6a36
to
1940227
Compare
Allure Report
smokeTests: ✅ test report for e7e4d1e4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@vetalcore |
71f6fea
to
5bf0ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once storybook changes have been corrected, happy to pass this on, looks like that's the only remaining change left. Great work 🎉
a33021c
to
21948b6
Compare
1a0625a
to
e200968
Compare
e200968
to
247d393
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the refactor, much easier to have all this in one place. Did you ever consider moving all translations into a single file?
Yeah i also wonder why the translations are still split up 🤔 since they are already namespaced it would make sense to merge them? (although we would have to namespace some of the extension translations i think) |
import styles from './SettingsLayout.module.scss'; | ||
import { useTranslation } from 'react-i18next'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure if that's the correct import?
it's just easier to handle the changes this way, we could easily implement that as a next iteration. |
Quality Gate passedIssues Measures |
Checklist
Proposed solution
Move all the translations files and i18n instance into the separate package.
Testing
All the translations should work the same as before.
Screenshots
Attach screenshots here if implementation involves some UI changes