Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long nft folder names wrapping in nft details #1146

Merged
merged 3 commits into from
May 13, 2024

Conversation

shawnbusuttil
Copy link
Contributor

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Create a folder name with maximum length and check nft details. Hover on it.

Screenshots

image

@shawnbusuttil shawnbusuttil added the browser Changes to the browser application. label May 9, 2024
@shawnbusuttil shawnbusuttil self-assigned this May 9, 2024
@shawnbusuttil shawnbusuttil requested a review from a team as a code owner May 9, 2024 21:36
@github-actions github-actions bot removed the browser Changes to the browser application. label May 9, 2024
@shawnbusuttil shawnbusuttil added the browser Changes to the browser application. label May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 1e33cd80

passed failed skipped flaky total result
Total 30 0 0 0 30

{folder && <Breadcrumb.Item>{folder}</Breadcrumb.Item>}
{folder && (
<Breadcrumb.Item>
<Tooltip label={folder}>{parseFolderName(folder)}</Tooltip>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an Elipsis component. Please use it instead. It has a built-in Tooltip 😉

@github-actions github-actions bot removed the browser Changes to the browser application. label May 10, 2024
@shawnbusuttil shawnbusuttil added the browser Changes to the browser application. label May 13, 2024
@github-actions github-actions bot removed the browser Changes to the browser application. label May 13, 2024
@shawnbusuttil shawnbusuttil enabled auto-merge (squash) May 13, 2024 15:16
Copy link

@shawnbusuttil shawnbusuttil merged commit c917148 into main May 13, 2024
12 checks passed
@shawnbusuttil shawnbusuttil deleted the fix/lw-10484-nft-long-folder-names branch May 13, 2024 15:41
@shawnbusuttil shawnbusuttil restored the fix/lw-10484-nft-long-folder-names branch May 13, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants