Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LW-10533] Assets list on the transaction summary page is broken #1145

Merged

Conversation

lucas-barros
Copy link

@lucas-barros lucas-barros commented May 9, 2024

Checklist


Proposed solution

Re add removed style and create story for automated UI snapshot test.

Testing

Create transaction with more than one asset

Screenshots

image

@lucas-barros lucas-barros marked this pull request as ready for review May 9, 2024 12:36
@lucas-barros lucas-barros requested a review from a team as a code owner May 9, 2024 12:36
@lucas-barros lucas-barros force-pushed the fix/lw-10533-assets-list-on-transaction-summary-page-broken branch from 32658ff to 37856f5 Compare May 9, 2024 12:43
Copy link

github-actions bot commented May 9, 2024

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for b9067080

passed failed skipped flaky total result
Total 30 0 0 0 30

Copy link
Contributor

@renanvalentin renanvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lucas-barros lucas-barros merged commit b453dc2 into main May 10, 2024
12 checks passed
@lucas-barros lucas-barros deleted the fix/lw-10533-assets-list-on-transaction-summary-page-broken branch May 10, 2024 11:29
mchappell pushed a commit that referenced this pull request May 10, 2024
* fix: style and add story

* fix: asset info overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants