Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extension): [LW-9230] add multi delegation and dapp issues modal #1133

Merged
merged 6 commits into from
May 17, 2024
Merged

feat(extension): [LW-9230] add multi delegation and dapp issues modal #1133

merged 6 commits into from
May 17, 2024

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented May 7, 2024 •
edited by jira bot
Loading

Checklist

  • JIRA - LW-9230
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Make use of existing pattern from staking package based on useOutsideHandles hook to pass proper state.

Testing

Check Scenario section from the description of ticket.

Screenshots

Screenshot 2024-05-07 at 17 03 33

@vetalcore vetalcore self-assigned this May 7, 2024
@vetalcore vetalcore requested a review from a team as a code owner May 7, 2024 14:08
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

Allure Report

allure-report-publisher generated test report!

smokeTests: ❌ test report for f7d2c269

passed failed skipped flaky total result
Total 29 1 0 0 30 ❌

przemyslaw-wlodek
przemyslaw-wlodek approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@przemyslaw-wlodek przemyslaw-wlodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 great work

@vetalcore vetalcore changed the title feat(extension): add multi delegation and dapp issues modal feat(extension): [LW-9230] add multi delegation and dapp issues modal May 8, 2024
@vetalcore vetalcore force-pushed the feat/lw-9230-multi-delegation-and-dapp-issues-modal branch 2 times, most recently from d20dce0 to 62f0d4b Compare May 9, 2024 08:06
@vetalcore vetalcore requested a review from a team as a code owner May 9, 2024 15:21
@vetalcore vetalcore force-pushed the feat/lw-9230-multi-delegation-and-dapp-issues-modal branch 7 times, most recently from 72d331b to a4d4f8c Compare May 15, 2024 09:09
@vetalcore vetalcore force-pushed the feat/lw-9230-multi-delegation-and-dapp-issues-modal branch from a4d4f8c to 4688efb Compare May 17, 2024 10:12
@vetalcore vetalcore enabled auto-merge (squash) May 17, 2024 10:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mchappell
mchappell approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very easy to scan PR, nice 🚀

@vetalcore vetalcore merged commit 7b2c88f into main May 17, 2024
9 of 10 checks passed
@vetalcore vetalcore deleted the feat/lw-9230-multi-delegation-and-dapp-issues-modal branch May 17, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wklos-iohk wklos-iohk wklos-iohk approved these changes

@przemyslaw-wlodek przemyslaw-wlodek przemyslaw-wlodek approved these changes

@szymonmaslowski szymonmaslowski szymonmaslowski approved these changes

@mchappell mchappell mchappell approved these changes

Assignees

@vetalcore vetalcore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vetalcore @mchappell @szymonmaslowski @przemyslaw-wlodek @wklos-iohk