Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LW-10289] replace Koralabs handleProvider with SDK handleHttpProvider #1132

Merged
merged 3 commits into from
May 7, 2024

Conversation

VanessaPC
Copy link
Contributor

@VanessaPC VanessaPC commented May 7, 2024

Checklist

  • JIRA - LW-10289
  • Proper tests implemented
  • Screenshots added.

Proposed solution

We want to start using handleHttpProvider instead of Koralabs, therefore we replace all instances and clean up imports.

Testing

  • Try to test handles, try to send to a handle, add a handle to address book, try to send to wrong handle and see it's not found.
  • Try to test subhandles as well in the same way.

Screenshots

Screenshot 2024-04-30 at 11 19 12
Screenshot 2024-04-30 at 11 19 07
Screenshot 2024-04-30 at 11 18 55
Screenshot 2024-04-30 at 11 18 48

@VanessaPC VanessaPC self-assigned this May 7, 2024
@VanessaPC VanessaPC requested a review from a team as a code owner May 7, 2024 12:54
Copy link

sonarqubecloud bot commented May 7, 2024

@VanessaPC VanessaPC changed the title Feat/lw 10289 use handleprovider from sdk two [LW-10289] replace Koralabs handleProvider with SDK handleHttpProvider May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 8b446e82

passed failed skipped flaky total result
Total 30 0 0 0 30

@VanessaPC VanessaPC merged commit 5f2c036 into main May 7, 2024
9 checks passed
@VanessaPC VanessaPC deleted the feat/LW-10289-use-handleprovider-from-SDK-two branch May 7, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants