-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LW-10244: Port HW onboarding revamp to multi wallet #1130
Merged
szymonmaslowski
merged 10 commits into
main
from
feat/LW-10244-port-HW-onboarding-revam-to-multi-wallet
May 14, 2024
Merged
LW-10244: Port HW onboarding revamp to multi wallet #1130
szymonmaslowski
merged 10 commits into
main
from
feat/LW-10244-port-HW-onboarding-revam-to-multi-wallet
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
smokeTests: ✅ test report for 9d0c9b25
|
Base automatically changed from
feat/lw-10249-revamp-multi-wallet-recovery-phrase-screen
to
main
May 7, 2024 10:37
szymonmaslowski
force-pushed
the
feat/LW-10244-port-HW-onboarding-revam-to-multi-wallet
branch
from
May 7, 2024 15:51
1c4fe29
to
1dd354c
Compare
greatertomi
approved these changes
May 8, 2024
...xtension-wallet/src/views/browser-view/features/multi-wallet/hardware-wallet/ErrorDialog.tsx
Show resolved
Hide resolved
…-onboarding-revam-to-multi-wallet
Quality Gate failedFailed conditions |
oldGreg5
approved these changes
May 14, 2024
szymonmaslowski
deleted the
feat/LW-10244-port-HW-onboarding-revam-to-multi-wallet
branch
May 14, 2024 10:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes