Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LW 9904] "UTxO Fully Depleted" error in send flow #1116

Merged
merged 25 commits into from
Jun 21, 2024
Merged

[LW 9904] "UTxO Fully Depleted" error in send flow #1116

merged 25 commits into from
Jun 21, 2024

Conversation

lucas-barros
Copy link

@lucas-barros lucas-barros commented Apr 30, 2024 •
edited
Loading

Checklist

Proposed solution

  • LW-9904: Display detailed error banner instead of input error message instructing the user to use "Max button"
  • LW-10450: Max amount concept for ADA is updated
    • from: total balance - minimum ADA for assets - 1 ADA
    • to: total balance - minimun ADA for assets - ADA buffer (buffer starts with 0 and is incremented by 1 ADA until tx is built successfully to account for UTXO depleted error)

Testing

  • Create new wallet and send ADA and assets to it. Try to send just ADA from the created wallet to another address.
  • Use wallet from LW-10450 and try to send 19,205 ADA to another address.

Screenshots

image image

@lucas-barros lucas-barros marked this pull request as ready for review April 30, 2024 14:24
@lucas-barros lucas-barros requested review from a team as code owners April 30, 2024 14:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for f222985a

passed failed skipped flaky total result
Total 33 0 0 0 33 ✅

renanvalentin
renanvalentin approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@renanvalentin renanvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

VanessaPC
VanessaPC reviewed May 1, 2024
View reviewed changes
Copy link
Contributor

@VanessaPC VanessaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small comment, but it looks good to me.
I cannot reproduce the banner.

apps/browser-extension-wallet/src/hooks/useInitializeTx.ts Show resolved Hide resolved
VanessaPC
VanessaPC approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@VanessaPC VanessaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomislavhoracek tomislavhoracek self-requested a review May 7, 2024 09:05
tomislavhoracek
tomislavhoracek reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucas-barros 💯
I left just one small suggestion

@lucas-barros lucas-barros force-pushed the feat/lw-9904-utxo-fully-depleted-error-in-send-flow branch 3 times, most recently from b8e38fb to 7194150 Compare May 10, 2024 16:40
lucas-barros
lucas-barros commented May 10, 2024
View reviewed changes
.../views/browser-view/features/send-transaction/components/Form/CoinInput/useSelectedCoins.tsx Outdated
@@ -157,6 +157,7 @@ export const useSelectedCoins = ({
compactValue: assetInputItem.compactValue || compactNumberWithUnit(assetInputItem.value),
value: assetInputItem.value,
hasMaxBtn: true,
displayMaxBtn: assetInputItem.id === cardanoCoin.id && error === COIN_SELECTION_ERRORS.FULLY_DEPLETED_ERROR,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display the max button without need for hover if error is FULLY_DEPLETED_ERROR

@lucas-barros lucas-barros force-pushed the feat/lw-9904-utxo-fully-depleted-error-in-send-flow branch 2 times, most recently from 4d15f13 to 1ed503c Compare May 13, 2024 12:42
DominikGuzei
DominikGuzei approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🎉

VanessaPC
VanessaPC approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@VanessaPC VanessaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomislavhoracek tomislavhoracek self-requested a review May 14, 2024 08:34
@lucas-barros lucas-barros force-pushed the feat/lw-9904-utxo-fully-depleted-error-in-send-flow branch 2 times, most recently from 4f67232 to b69e8eb Compare May 22, 2024 19:49
@lucas-barros lucas-barros force-pushed the feat/lw-9904-utxo-fully-depleted-error-in-send-flow branch from b69e8eb to 3bbdd79 Compare May 23, 2024 11:08
@lucas-barros lucas-barros force-pushed the feat/lw-9904-utxo-fully-depleted-error-in-send-flow branch from fb25825 to f0cf533 Compare May 28, 2024 01:19
Lucas Araujo and others added 13 commits May 28, 2024 22:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lucas-barros lucas-barros merged commit 23bd9d4 into main Jun 21, 2024
19 of 26 checks passed
@lucas-barros lucas-barros deleted the feat/lw-9904-utxo-fully-depleted-error-in-send-flow branch June 21, 2024 12:06
@pczeglik-iohk pczeglik-iohk mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bslabiak bslabiak bslabiak approved these changes

@VanessaPC VanessaPC VanessaPC approved these changes

@renanvalentin renanvalentin renanvalentin approved these changes

@DominikGuzei DominikGuzei DominikGuzei approved these changes

@tomislavhoracek tomislavhoracek Awaiting requested review from tomislavhoracek

Assignees

@lucas-barros lucas-barros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lucas-barros @DominikGuzei @renanvalentin @VanessaPC @tomislavhoracek @bslabiak @ljagiela