Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(extension): use drep registration tracker #1115

Merged
merged 3 commits into from
May 7, 2024

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Apr 30, 2024

Checklist

  • JIRA - LW-10236
  • Proper tests implemented
  • Screenshots added.

Proposed solution

use isRegisteredAsDrep observable available on observable wallet.

Testing

same as in https://input-output.atlassian.net/browse/LW-9202

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore self-assigned this Apr 30, 2024
@vetalcore vetalcore requested a review from a team as a code owner April 30, 2024 14:20
@vetalcore vetalcore force-pushed the chore/lw-10236-use-drep-registration-tracker branch from f6e4f88 to e928952 Compare April 30, 2024 14:20
Copy link
Collaborator

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation

Copy link

github-actions bot commented Apr 30, 2024

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 9d90637a

passed failed skipped flaky total result
Total 30 0 0 0 30

@vetalcore vetalcore enabled auto-merge (squash) May 1, 2024 12:16
@vetalcore vetalcore disabled auto-merge May 1, 2024 12:16
@vetalcore vetalcore enabled auto-merge (squash) May 7, 2024 12:20
@vetalcore vetalcore force-pushed the chore/lw-10236-use-drep-registration-tracker branch from 581d052 to 9d90637 Compare May 7, 2024 12:52
Copy link

sonarqubecloud bot commented May 7, 2024

@vetalcore vetalcore merged commit 0bb7467 into main May 7, 2024
9 checks passed
@vetalcore vetalcore deleted the chore/lw-10236-use-drep-registration-tracker branch May 7, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants