[LW-10289] replace Koralabs handleProvider with SDK handleHttpProvider #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanessaPC
force-pushed
the
feat/LW-10289-use-handleprovider-from-SDK
branch
from
12945ec to
347e175
Compare
Allure Report
smokeTests: ❌ test report for 60febca0
|
VanessaPC
force-pushed
the
feat/LW-10289-use-handleprovider-from-SDK
branch
2 times, most recently
from
0bfa6bd to
7571e0c
Compare
VanessaPC
force-pushed
the
feat/LW-10289-use-handleprovider-from-SDK
branch
from
09e87e3 to
d42dc71
Compare
| [Cardano.NetworkMagics.Preview]: 'https://preview.api.handle.me' | ||
| [Cardano.NetworkMagics.Mainnet]: 'https://live-preprod.lw.iog.io/', | ||
| [Cardano.NetworkMagics.Preprod]: 'https://dev-preprod.lw.iog.io/', | ||
| [Cardano.NetworkMagics.Preview]: 'https://dev-preview.lw.iog.io/' |
There was a problem hiding this comment.
Shouldn't we use the .env vars here instead of hardcoded values?
lucas-barros
approved these changes
Apr 30, 2024
apps/browser-extension-wallet/src/features/ada-handle/config.ts
Outdated
Show resolved
Hide resolved
VanessaPC
force-pushed
the
feat/LW-10289-use-handleprovider-from-SDK
branch
from
75f4fcd to
2d0ad44
Compare
lucas-barros
approved these changes
May 1, 2024
apps/browser-extension-wallet/src/utils/validators/address-book.ts
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/utils/validators/address-book.ts
Outdated
Show resolved
Hide resolved
tomislavhoracek
approved these changes
May 2, 2024
VanessaPC
force-pushed
the
feat/LW-10289-use-handleprovider-from-SDK
branch
from
9c4346b to
e214c38
Compare
VanessaPC
force-pushed
the
feat/LW-10289-use-handleprovider-from-SDK
branch
from
705519f to
60febca
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
We want to start using
handleHttpProviderinstead of Koralabs, therefore we replace all instances and clean up imports.Testing
Screenshots