refactor(core): refactor activityDetails to use dApp components [LW-10281] #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
smokeTests: ✅ test report for dbca45f2
|
przemyslaw-wlodek
requested changes
May 6, 2024
There was a problem hiding this comment.
Great refactor @tommayeliog! 🚀 Please take a look if my comments are helpful. We can catch up :)
...nsion-wallet/src/views/browser-view/features/activity/components/TransactionDetailsProxy.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/ui/components/ActivityDetail/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/ui/components/ProposalProcedures/components/ProcedureTransactionDetails.tsx
Outdated
Show resolved
Hide resolved
...s/core/src/ui/components/ActivityDetail/components/TxDetailsCertificates/CertificateView.tsx
Outdated
Show resolved
Hide resolved
...s/core/src/ui/components/ActivityDetail/components/TxDetailsCertificates/CertificateView.tsx
Outdated
Show resolved
Hide resolved
...s/core/src/ui/components/ActivityDetail/components/TxDetailsCertificates/CertificateView.tsx
Show resolved
Hide resolved
.../src/ui/components/ActivityDetail/components/TxDetailsCertificates/TxDetailsCertificates.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/ui/components/ActivityDetail/components/TxDetailsProposalProcedures.tsx
Outdated
Show resolved
Hide resolved
| <VotingProcedures data={Wallet.util.votingProceduresRawToViewMap(votingProcedures, explorerBaseUrl)} /> | ||
| <VotingProcedures | ||
| data={votingProcedures.map((votingProcedure) => | ||
| Wallet.util.mapVotingProceduresToView(votingProcedure, explorerBaseUrl) |
There was a problem hiding this comment.
mapVotingProceduresToView -> mapVotingProcedureToView
tommayeliog
changed the title
przemyslaw-wlodek
approved these changes
May 8, 2024
wklos-iohk
approved these changes
May 21, 2024
tommayeliog
force-pushed
the
refactor/LW-10281-dApp-connector-screens-activity-details
branch
from
bebeac9 to
9cfb48d
Compare
|
mchappell
approved these changes
May 21, 2024
tommayeliog
deleted the
refactor/LW-10281-dApp-connector-screens-activity-details
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
In this PR I'm making a refactoring that will use core dApp components for both dApp modal and for TransactionDetails screen, more specifically: certificates, proposalProcedures and voteProcedures.
Core and Extension packages are using shared functions for raw data mapping and test/storybook mocks.
Note: DappInfo has been removed from core certificates/proposal components and it's on the containers in extenstion package.
Testing
Use storybook and
yarn testfor testing both extension and core.If you are able to test the application, then check is it correct when switching networks.
Screenshots