Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LW-9597] Transaction expiry date #1008

Merged
merged 2 commits into from
May 8, 2024
Merged

[LW-9597] Transaction expiry date #1008

merged 2 commits into from
May 8, 2024

Conversation

lucas-barros
Copy link

@lucas-barros lucas-barros commented Apr 1, 2024 •
edited
Loading

Checklist

Proposed solution

Add expiry date for send flow and dapp transaction confirmation.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

image image

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for ee45dba8

passed failed skipped flaky total result
Total 30 0 0 0 30 ✅

@coveralls
Copy link

coveralls commented Apr 1, 2024 •
edited
Loading

Coverage Status

coverage: 50.667% (+0.1%) from 50.56%
when pulling aeba5afe56fd05b746a775dc8e3d22b240edeb95 on feat/lw-9597-transaction-expiry-date
into 1045749 on main.

@lucas-barros lucas-barros force-pushed the feat/lw-9597-transaction-expiry-date branch 4 times, most recently from 4dc541b to 1eabb6a Compare April 2, 2024 17:28
@lucas-barros lucas-barros marked this pull request as ready for review April 3, 2024 00:09
@lucas-barros lucas-barros requested a review from a team as a code owner April 3, 2024 00:09
VanessaPC
VanessaPC requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@VanessaPC VanessaPC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, also, what does it happen when a transaction validity interval is expired? currently the dapp-connector doesn't open.

packages/core/src/ui/components/DappTransaction/DappTransaction.tsx Show resolved Hide resolved
packages/core/src/ui/components/OutputSummaryList/OutputSummaryList.tsx Show resolved Hide resolved
packages/ui/src/design-system/dapp-transaction-summary/dapp-transaction-field.component.tsx Outdated Show resolved Hide resolved
@lucas-barros
Copy link
Author

A few small comments, also, what does it happen when a transaction validity interval is expired? currently the dapp-connector doesn't open.

I'm not sure. The submitted transaction should fail, but I don't know why dapp connector doesnt open.

@VanessaPC
Copy link
Contributor

A few small comments, also, what does it happen when a transaction validity interval is expired? currently the dapp-connector doesn't open.

I'm not sure. The submitted transaction should fail, but I don't know why dapp connector doesnt open.

It does fail.. but silently. That's on your branch. If you want to see it yourself, I can tell you where the dapp connector is..
Screenshot 2024-04-03 at 16 24 55

@lucas-barros lucas-barros requested a review from VanessaPC April 4, 2024 13:24
VanessaPC
VanessaPC approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@VanessaPC VanessaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀 !

@lucas-barros lucas-barros force-pushed the feat/lw-9597-transaction-expiry-date branch from 9b5efa1 to d23cffd Compare April 4, 2024 14:12
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lucas-barros lucas-barros merged commit 0fd1666 into main May 8, 2024
15 checks passed
@lucas-barros lucas-barros deleted the feat/lw-9597-transaction-expiry-date branch May 8, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljagiela ljagiela ljagiela approved these changes

@VanessaPC VanessaPC VanessaPC approved these changes

@DominikGuzei DominikGuzei DominikGuzei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucas-barros @coveralls @VanessaPC @DominikGuzei @ljagiela