From 379e9f1429586a4d540f8f813ee788ff21664887 Mon Sep 17 00:00:00 2001 From: Lukasz Jagiela <12641433+ljagiela@users.noreply.github.com> Date: Wed, 11 Dec 2024 14:20:25 +0100 Subject: [PATCH] test: e2e - fix/tag failing tests (maintenance) (#1587) --- .../src/assert/settings/MessageSigningAllDoneDrawerAssert.ts | 5 +---- .../src/elements/settings/MessageSigningAllDoneDrawer.ts | 5 ----- packages/e2e-tests/src/features/SignMessage.feature | 2 +- .../src/features/analytics/AnalyticsOnboardingEvents.feature | 3 ++- 4 files changed, 4 insertions(+), 11 deletions(-) diff --git a/packages/e2e-tests/src/assert/settings/MessageSigningAllDoneDrawerAssert.ts b/packages/e2e-tests/src/assert/settings/MessageSigningAllDoneDrawerAssert.ts index 61f30476b0..29ae8764eb 100644 --- a/packages/e2e-tests/src/assert/settings/MessageSigningAllDoneDrawerAssert.ts +++ b/packages/e2e-tests/src/assert/settings/MessageSigningAllDoneDrawerAssert.ts @@ -14,10 +14,7 @@ class MessageSigningAllDoneDrawerAssert { await MessageSigningAllDoneDrawer.image.waitForDisplayed(); await MessageSigningAllDoneDrawer.title.waitForDisplayed(); expect(await MessageSigningAllDoneDrawer.title.getText()).to.equal(await t('core.signMessage.successTitle')); - await MessageSigningAllDoneDrawer.description.waitForDisplayed(); - expect(await MessageSigningAllDoneDrawer.description.getText()).to.equal( - await t('core.signMessage.successDescription') - ); + await MessageSigningAllDoneDrawer.signature.waitForDisplayed(); expect(await MessageSigningAllDoneDrawer.signature.getText()).to.not.be.empty; diff --git a/packages/e2e-tests/src/elements/settings/MessageSigningAllDoneDrawer.ts b/packages/e2e-tests/src/elements/settings/MessageSigningAllDoneDrawer.ts index 9a589ff7fd..6350a07c02 100644 --- a/packages/e2e-tests/src/elements/settings/MessageSigningAllDoneDrawer.ts +++ b/packages/e2e-tests/src/elements/settings/MessageSigningAllDoneDrawer.ts @@ -5,7 +5,6 @@ import type { ChainablePromiseElement } from 'webdriverio'; class MessageSigningAllDoneDrawer extends CommonDrawerElements { private IMAGE = '[data-testid="result-message-img"]'; private TITLE = '[data-testid="result-message-title"]'; - private DESCRIPTION = '[data-testid="result-message-description"]'; private SIGNATURE = '[data-testid="sign-message-signature"]'; private SIGNATURE_LABEL = '[data-testid="result-message-signature-label"]'; private KEY = '[data-testid="sign-message-key"]'; @@ -21,10 +20,6 @@ class MessageSigningAllDoneDrawer extends CommonDrawerElements { return $(this.TITLE); } - get description(): ChainablePromiseElement { - return $(this.DESCRIPTION); - } - get signature(): ChainablePromiseElement { return $(this.SIGNATURE); } diff --git a/packages/e2e-tests/src/features/SignMessage.feature b/packages/e2e-tests/src/features/SignMessage.feature index 69c08388c2..ccfe4a5f63 100644 --- a/packages/e2e-tests/src/features/SignMessage.feature +++ b/packages/e2e-tests/src/features/SignMessage.feature @@ -40,7 +40,7 @@ Feature: Sign message # For 3rd account from TestAutomationWallet | addr_test1qpvl49m3p8z8cmlqrmm...mhy2p8sqj0rsdf | - @LW-11539 + @LW-11539 @Smoke Scenario: Extended view - Sign message - happy path When I click the menu button And I click on the "Sign message" option diff --git a/packages/e2e-tests/src/features/analytics/AnalyticsOnboardingEvents.feature b/packages/e2e-tests/src/features/analytics/AnalyticsOnboardingEvents.feature index d22bfc6de9..b38b2a3b59 100644 --- a/packages/e2e-tests/src/features/analytics/AnalyticsOnboardingEvents.feature +++ b/packages/e2e-tests/src/features/analytics/AnalyticsOnboardingEvents.feature @@ -34,7 +34,8 @@ Feature: Analytics - Posthog - Onboarding - Extended View | $create_alias | And I validate that alias event has assigned same user id "5b3ca1f1f7a14aad1e79f46213e2777d" in posthog - @LW-7365 + @LW-7365 @Pending + @issue=LW-11971 Scenario: Analytics - Onboarding new wallet events Given "Get started" page is displayed When I enable showing Analytics consent banner