Do not truncate the list of peers for propagation #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinor
reviewed
Feb 6, 2020
The vector obtained from Topology::view is sorted by node ID, so truncations make the network biased toward nodes with low IDs. Let the client connections rotate "naturally", allowing some churn. A limit on the view size should be implemented in Poldercast: primetype/poldercast#6
mzabaluev
force-pushed
the
no-topology-view-truncation
branch
from
11bba01 to
7608a33
Compare
rinor
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vector obtained from
Topology::viewis sorted by node ID, so truncations make the network biased toward nodes with low IDs.Let the client connections rotate "naturally", allowing some churn.
A limit on the view size should be implemented in Poldercast:
primetype/poldercast#6