error: the borrowed expression implements the required traits --> catalyst-toolbox/src/stats/live/harvester.rs:50:18 | 50 | .get(&format!("{}/v0/fragment/logs", self.endpoint)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/v0/fragment/logs", self.endpoint)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this OR pattern can be rewritten using a range --> catalyst-toolbox/src/snapshot.rs:183:9 | 183 | 0x0 | 0x1 | 0x2 | 0x3 | 0x4 | 0x5 | 0x6 | 0x7 => AddrType::Shelley, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `0..=7` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns = note: `-D clippy::manual-range-patterns` implied by `-D warnings`

error: casting integer literal to `u64` is unnecessary --> catalyst-toolbox/src/snapshot.rs:80:37 | 80 | ... value / 1_000_000 as u64 | ^^^^^^^^^^^^^^^^ help: try: `1_000_000_u64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-D clippy::unnecessary-cast` implied by `-D warnings`

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> catalyst-toolbox/src/rewards/voters.rs:88:16 | 88 | .chain(vote_count.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `vote_count` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> catalyst-toolbox/src/rewards/veterans.rs:128:14 | 128 | .zip(rewards_eligible_rankings.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `rewards_eligible_rankings` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings`

error: the `Err`-variant returned from this function is very large --> catalyst-toolbox/src/recovery/tally.rs:582:10 | 582 | ) -> Result<ReplayedFragment, (Error, Fragment)> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 344 bytes | = help: try reducing the size of `(recovery::tally::Error, chain_impl_mockchain::fragment::Fragment)`, for example by boxing large elements or replacing it with `Box<(recovery::tally::Error, chain_impl_mockchain::fragment::Fragment)>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

error: the borrowed expression implements the required traits --> catalyst-toolbox/src/recovery/tally.rs:548:25 | 548 | &mut rand::thread_rng(), | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `rand::thread_rng()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: the `Err`-variant returned from this function is very large --> catalyst-toolbox/src/recovery/tally.rs:529:63 | 42 | LedgerError(#[from] chain_impl_mockchain::ledger::Error), | -------------------------------------------------------- the largest variant contains at least 264 bytes ... 529 | fn replay_tx(&mut self, tx: TransactionSlice<NoExtra>) -> Result<Fragment, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `recovery::tally::Error`, for example by boxing large elements or replacing it with `Box<recovery::tally::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

error: the `Err`-variant returned from this function is very large --> catalyst-toolbox/src/recovery/tally.rs:505:70 | 42 | LedgerError(#[from] chain_impl_mockchain::ledger::Error), | -------------------------------------------------------- the largest variant contains at least 264 bytes ... 505 | fn replay_votecast(&mut self, tx: TransactionSlice<VoteCast>) -> Result<Fragment, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `recovery::tally::Error`, for example by boxing large elements or replacing it with `Box<recovery::tally::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

error: the `Err`-variant returned from this function is very large --> catalyst-toolbox/src/recovery/tally.rs:438:39 | 42 | LedgerError(#[from] chain_impl_mockchain::ledger::Error), | -------------------------------------------------------- the largest variant contains at least 264 bytes ... 438 | fn from_block0(block0: &Block) -> Result<(Self, Block), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `recovery::tally::Error`, for example by boxing large elements or replacing it with `Box<recovery::tally::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

error: the `Err`-variant returned from this function is very large --> catalyst-toolbox/src/recovery/tally.rs:353:6 | 42 | LedgerError(#[from] chain_impl_mockchain::ledger::Error), | -------------------------------------------------------- the largest variant contains at least 264 bytes ... 353 | ) -> Result<(Ledger, Vec<Fragment>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `recovery::tally::Error`, for example by boxing large elements or replacing it with `Box<recovery::tally::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

error: the `Err`-variant returned from this function is very large --> catalyst-toolbox/src/recovery/tally.rs:248:73 | 42 | LedgerError(#[from] chain_impl_mockchain::ledger::Error), | -------------------------------------------------------- the largest variant contains at least 264 bytes ... 248 | pub fn new(block0: Block, range_check: Range<u32>, fragments: I) -> Result<Self, Error> { | ^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `recovery::tally::Error`, for example by boxing large elements or replacing it with `Box<recovery::tally::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

error: the borrowed expression implements the required traits --> catalyst-toolbox/src/recovery/replay.rs:56:47 | 56 | .format_json(serde_json::to_value(&voteplan_status)?)?; | ^^^^^^^^^^^^^^^^ help: change this to: `voteplan_status` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: the `Err`-variant returned from this function is very large --> catalyst-toolbox/src/recovery/replay.rs:39:26 | 39 | pub fn exec(self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^ ... 72 | Recovery(#[from] crate::recovery::tally::Error), | ----------------------------------------------- the largest variant contains at least 264 bytes | = help: try reducing the size of `recovery::replay::Error`, for example by boxing large elements or replacing it with `Box<recovery::replay::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `-D clippy::result-large-err` implied by `-D warnings`

error: the borrowed expression implements the required traits --> catalyst-toolbox/src/kedqr/payload.rs:34:33 | 34 | let key = decrypt(password, &encrypted_bytes)?; | ^^^^^^^^^^^^^^^^ help: change this to: `encrypted_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: the borrowed expression implements the required traits --> catalyst-toolbox/src/kedqr/img.rs:50:57 | 50 | let inner = QrCode::with_error_correction_level(&enc_hex, EcLevel::H).unwrap(); | ^^^^^^^^ help: change this to: `enc_hex` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: unnecessary closure used with `bool::then` --> catalyst-toolbox/src/ideascale/mod.rs:130:37 | 130 | challenge_type: funnels | _____________________________________^ 131 | | .get(&c.funnel_id) 132 | | .unwrap_or_else(|| panic!("A funnel with id {} wasn't found", c.funnel_id)) 133 | | .is_community() 134 | | .then(|| "community-choice") | |__________________________--------------------------^ | | | help: use `then_some(..)` instead: `then_some("community-choice")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`

error: the borrowed expression implements the required traits --> catalyst-toolbox/src/ideascale/models/de.rs:183:30 | 183 | D::Error::custom(&format!( | ______________________________^ 184 | | "Unable to read malformed value: '{}'", 185 | | rewards_str 186 | | )) | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` help: change this to | 183 ~ D::Error::custom(format!( 184 + "Unable to read malformed value: '{}'", 185 + rewards_str 186 ~ )) |