Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): Use report_duplicated_key from catalyst-types everywhere #184

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Jan 27, 2025

Description

  • Use report_duplicated_key and report_missing_keys function in rbac-registration and cardano-blockchain-types.

Related Pull Requests

#180

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit 3017ece into main Jan 27, 2025
22 checks passed
@stanislav-tkach stanislav-tkach deleted the remove-report_duplicated_key-duplication branch January 27, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants