Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust/catalyst-types): Add report_duplicated_key and report_missing_keys functions to catalyst-types #180

Merged

Conversation

stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Jan 27, 2025

Description

Add report_duplicated_key and report_missing_keys functions to the catalyst-types crate.

Related Pull Requests

#178

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stanislav-tkach stanislav-tkach changed the title Add report_duplicated_key and report_missing_keys functions to catalyst-types feat(rust/catalyst-types): Add report_duplicated_key and report_missing_keys functions to catalyst-types Jan 27, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@stanislav-tkach stanislav-tkach self-assigned this Jan 27, 2025
@stanislav-tkach stanislav-tkach added the review me PR is ready for review label Jan 27, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit 6d962b2 into main Jan 27, 2025
20 of 22 checks passed
@stanislav-tkach stanislav-tkach deleted the catalyst-types-report_duplicated_key-report_missing_keys branch January 27, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants