Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(general): Enable arithmetic_side_effects Clippy lint #179

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Jan 26, 2025

Description

  • Enable the arithmetic_side_effects Clippy lint and fix the generated warnings.

Related Issue(s)

Related to input-output-hk/catalyst-voices#1467.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stanislav-tkach stanislav-tkach changed the title feat(rust/general): Enable arithmetic_side_effects Clippy lint chore(general): Enable arithmetic_side_effects Clippy lint Jan 26, 2025
@stanislav-tkach stanislav-tkach force-pushed the arithmetic_side_effects-clippy-lint branch 2 times, most recently from b0564f4 to ef7373e Compare January 26, 2025 17:57
@stanislav-tkach stanislav-tkach force-pushed the arithmetic_side_effects-clippy-lint branch from ef7373e to 6434be2 Compare January 26, 2025 19:31
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@stanislav-tkach stanislav-tkach added the review me PR is ready for review label Jan 27, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

rust/c509-certificate/src/attributes/mod.rs Outdated Show resolved Hide resolved
rust/c509-certificate/src/general_names/mod.rs Outdated Show resolved Hide resolved
rust/c509-certificate/src/name/mod.rs Outdated Show resolved Hide resolved
rust/c509-certificate/src/name/mod.rs Outdated Show resolved Hide resolved
rust/cardano-chain-follower/examples/follow_chains.rs Outdated Show resolved Hide resolved
rust/catalyst-voting/src/lib.rs Show resolved Hide resolved
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit 2aab21d into main Jan 28, 2025
17 of 22 checks passed
@stanislav-tkach stanislav-tkach deleted the arithmetic_side_effects-clippy-lint branch January 28, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants