Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust/cardano-chain-follower): Update mithril-client version (0.8.18 -> 0.10.4) #110

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Dec 17, 2024

Description

  • mithril-client version was updated from 0.8.18 to 0.10.4.

Description of Changes

Currently we have broken builds in the main branch because of the mithril-common update (dependency of mithril-client).

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stanislav-tkach stanislav-tkach self-assigned this Dec 17, 2024
@stanislav-tkach stanislav-tkach changed the title fix(cardano-chain-follower): Update mithril-client version (0.8.18 -> 0.10.4) fix(rust/cardano-chain-follower): Update mithril-client version (0.8.18 -> 0.10.4) Dec 17, 2024
@stanislav-tkach stanislav-tkach force-pushed the update-mithril-client-version branch from bfa4859 to d8600d6 Compare December 17, 2024 12:26
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 228/228}$ | ${\color{red}Fail: 0/228}$ |

@stanislav-tkach stanislav-tkach marked this pull request as ready for review December 17, 2024 12:37
@stanislav-tkach stanislav-tkach added the review me PR is ready for review label Dec 17, 2024
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit ef7261f into main Dec 17, 2024
34 checks passed
@stanislav-tkach stanislav-tkach deleted the update-mithril-client-version branch December 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants