Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for fdcDeprecation #154

Closed
wants to merge 4 commits into from
Closed

PR for fdcDeprecation #154

wants to merge 4 commits into from

Conversation

alicechaitea
Copy link
Contributor

@alicechaitea alicechaitea commented Jan 12, 2024 •
edited
Loading

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #123, Resolves #456 Fixes #367

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

jmgilman and others added 4 commits January 9, 2024 17:48
@jmgilman
fix: makes building docs optional (#150)
c46044c
@stevenj
feat(adr): Add ADRs for Languages and Rust (#149)
23c3d7b 
* docs(docs): Bump mkdocs and dependent library versions to current latest

* fix(docs): update lock file

* docs(ADR): Add ADR's for Language/Spelling and Rust

* docs(mdlint): Fix line length issue

* fix(docs): Rust ADRs are draft, and fix spelling
@kukkok3
fix: Move target flags after target (#151)
7a775d5 
* move target flags after target

* fix: tests
@bkioshn
fix: allow target hyphenated alphanumeric sequence (#153)
862b83a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alicechaitea @jmgilman @stevenj @kukkok3 @bkioshn