Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web-extension)!: make KeyAgentFactory methods async #1564

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mkazlauskas
Copy link
Member

Context

Bip32Ed25519 was refactored to synchronous methods by hoisting sodium await to top level in #1558, which makes it difficult to use SigningCoordinator without top level await

Proposed Solution

Important Changes Introduced

@mkazlauskas mkazlauskas requested review from przemyslaw-wlodek and a team January 21, 2025 06:15
AngelCastilloB
AngelCastilloB previously approved these changes Jan 21, 2025
Copy link
Member

@AngelCastilloB AngelCastilloB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@przemyslaw-wlodek przemyslaw-wlodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM. Thank you!

Bip32Ed25519 was refactored to synchronous methods by hoisting
sodium await to top level in #1558, which makes it difficult
to use SigningCoordinator without top level await
@mkazlauskas mkazlauskas force-pushed the refactor/async-key-agent-factory branch from a9a8ab8 to 069b2b5 Compare January 21, 2025 07:02
@mkazlauskas mkazlauskas merged commit 7f95590 into master Jan 21, 2025
5 of 6 checks passed
@mkazlauskas mkazlauskas deleted the refactor/async-key-agent-factory branch January 21, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants