-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fatal provider errors #1550
Conversation
this util is not Provider-aware it resides in 'util-rxjs' package, which does not depend on 'core' follow-up commit will add a new Provider-aware util that knows about retryable ProviderErrors BREAKING CHANGE: rename poll props 'provider' to 'sample'
BaseWallet was retrying all errors, which could potentially hide bugs by retrying something that will never recover BREAKING CHANGE: BaseWallet observables error instead of emitting fatalError$ - remove ObservableError.fatalError$ - 'poll' util observable errors instead of calling onFatalError - remove PollProps.onFatalError - 'poll' no longer checks for InvalidStringError, it's up to consumer
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mkazlauskas!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here @mkazlauskas 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great refactor 👏
Context
LW-11945
Proposed Solution
See commits
Important Changes Introduced