feat(tx-construction): throw when deregistering reward accounts with … #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/tx-construction/src/tx-builder/ensureNoDeRegistrationsWithRewardsLocked.ts
Outdated
Show resolved
Hide resolved
szymonmaslowski
force-pushed
the
fix/lw-11898-unstake-account-with-rewards-but-no-vote-delegation
branch
2 times, most recently
from
10c64d5 to
a169345
Compare
|
| import { hasCorrectVoteDelegation } from './hasCorrectVoteDelegation'; | ||
| import type { RewardAccountWithPoolId } from '../types'; | ||
|
|
||
| export const ensureNoDeRegistrationsWithRewardsLocked = (rewardAccountsToBeDeRegistered: RewardAccountWithPoolId[]) => { |
There was a problem hiding this comment.
Sorry for the nitpicking. Could you reduce this type too?
- export const ensureNoDeRegistrationsWithRewardsLocked = (rewardAccountsToBeDeRegistered: RewardAccountWithPoolId[]) => {
+ export const ensureNoDeRegistrationsWithRewardsLocked = (rewardAccountsToBeDeRegistered: Pick<RewardAccountWithPoolId, 'dRepDelegatee' | 'rewardBalance'>[]) => {There was a problem hiding this comment.
I would not reduce it here. This function uses hasCorrectVoteDelegation function which has that type already reduced so reducing it here would create an implicit relation between them as the ensureNoDeRegistrationsWithRewardsLocked would need to pick dRepDelegatee despite not using it
| export class DeRegistrationsWithRewardsLocked extends CustomError { | ||
| keysWithLockedRewards: DataOfKeyWithLockedRewards[]; | ||
|
|
||
| public constructor(rewardAccounts: RewardAccountWithPoolId[]) { |
There was a problem hiding this comment.
- public constructor(rewardAccounts: RewardAccountWithPoolId[]) {
+ public constructor(rewardAccounts: Pick<RewardAccountWithPoolId, 'address'>[]) {| const createTxBuilderWithDreps = createTxBuilderWithRewardBalance(0n); | ||
| const txBuilderFactory = await createTxBuilderWithDreps(...drepValues); | ||
|
|
||
| await txBuilderFactory.txBuilder.delegatePortfolio(null).build().inspect(); |
There was a problem hiding this comment.
Maybe best to wrap in an expect statement:
- await txBuilderFactory.txBuilder.delegatePortfolio(null).build().inspect();
+ await expect(() => txBuilderFactory.txBuilder.delegatePortfolio(null).build().inspect()).resolves.not.toThrow();| @@ -853,4 +865,131 @@ describe('TxBuilder/delegatePortfolio', () => { | |||
| expect(roundRobinRandomImprove).toHaveBeenCalled(); | |||
| }); | |||
| }); | |||
|
|
|||
| // eslint-disable-next-line sonarjs/cognitive-complexity | |||
| describe('DRep delegation', () => { | |||
There was a problem hiding this comment.
Very well written tests. Great coverage and easy to ready ❤️ 👏
| }); | ||
| }); | ||
|
|
||
| it('attaches data of all locked locked reward account to the DeRegistrationsWithRewardsLocked error', async () => { |
There was a problem hiding this comment.
tiny typo
- it('attaches data of all locked locked reward account to the DeRegistrationsWithRewardsLocked error', async () => {
+ it('attaches data of all locked reward accounts to the DeRegistrationsWithRewardsLocked error', async () => {
mirceahasegan
previously approved these changes
Dec 20, 2024
szymonmaslowski
dismissed stale reviews from mkazlauskas and mirceahasegan
via
c03d01f
szymonmaslowski
force-pushed
the
fix/lw-11898-unstake-account-with-rewards-but-no-vote-delegation
branch
from
a169345 to
c03d01f
Compare
…rewards without drep
szymonmaslowski
force-pushed
the
fix/lw-11898-unstake-account-with-rewards-but-no-vote-delegation
branch
from
c03d01f to
c594937
Compare
Open
3 tasks
mkazlauskas
approved these changes
Jan 2, 2025
szymonmaslowski
deleted the
fix/lw-11898-unstake-account-with-rewards-but-no-vote-delegation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rewards without drep
Context
After Chang Fork it will become impossible to deregister stake keys with rewards but without vote delegation. We want to show an error in lace when this situation occur during removing stake pools from portfolio.
Proposed Solution
Detect such case and throw an error with a set of required data so lace could list the affected keys.
Important Changes Introduced