-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lw 10449 sdk e2e tests ci #1332
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KEY_MANAGEMENT_PARAMS needs to be fixed, other than that if it works - its good
4c9cd64
to
75d7c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes... but great job! Thank you
1047224
to
56f1187
Compare
- Create shell script to generate .env file for workflow - Add new workflow definition for tests
fb421ef
to
a95d2dc
Compare
if [[ "${{ inputs.environment }}" == *"preprod"* ]]; then networkMagic=1; else networkMagic=2; fi | ||
./src/scripts/generate-dotenv.sh ${{ inputs.environment }} | ||
echo "KEY_MANAGEMENT_PARAMS='$(jq --argjson networkMagic $networkMagic --arg mnemonic "${{ secrets.MNEMONIC }}" <<< '{"bip32Ed25519": "Sodium", "accountIndex": 0, "chainId":{"networkId": 0, "networkMagic": 0}, "passphrase":"some_passphrase","mnemonic":"mnemonics"}' '.mnemonic=$mnemonic | .chainId.networkMagic=$networkMagic')'" >> .env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this logic into the script?
off the top of my head, I cant remember network magics, but I would like for us to use map for it https://stackoverflow.com/questions/688849/associative-arrays-in-shell-scripts or else if with exit 1 if it cant find the required one
this part will require few tweaks to support secret wallets but I think its fine for first iteration. These changes that I mention can wait till then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exceptional job! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you :)
Context
Background
An easy to run CI action should be available to quickly sanitize SRE deployments (e.g. dev-preprod).
DoD
CI action can be run targeting different deployments.
An env variable (or such) should be configurable to determine which deployment we are targeting
…
https://input-output.atlassian.net/browse/LW-10449
Reason for the change? If an issue exists, reference it here using a keyword
Proposed Solution
Important Changes Introduced