Merge pull request #1117 from input-output-hk/feat/lw-9901-transactio…

…nBody-serializes-incorrectly-if-no-inputs fix(core): transaction body can now serializes bodies with no inputs correctly
input-output-hk · Feb 29, 2024 · e85871e · e85871e
2 parents 50e9558 + 13800d6
commit e85871e
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/packages/core/src/Serialization/TransactionBody/TransactionBody.ts b/packages/core/src/Serialization/TransactionBody/TransactionBody.ts
@@ -990,7 +990,7 @@ export class TransactionBody {
     let mapSize = 0;
 
     if (this.#inputs !== undefined && this.#inputs.length > 0) ++mapSize;
-    if (this.#outputs !== undefined && this.#inputs.length > 0) ++mapSize;
+    if (this.#outputs !== undefined && this.#outputs.length > 0) ++mapSize;
     if (this.#fee !== undefined) ++mapSize;
     if (this.#ttl !== undefined) ++mapSize;
     if (this.#certs !== undefined && this.#certs.length > 0) ++mapSize;

diff --git a/packages/core/test/Serialization/TransactionBody/TransactionBody.test.ts b/packages/core/test/Serialization/TransactionBody/TransactionBody.test.ts
@@ -65,6 +65,23 @@ export const core: Cardano.TxBody = {
   ]
 };
 
+export const noInputsCore: Cardano.TxBody = {
+  certificates: [
+    {
+      __typename: Cardano.CertificateType.PoolRetirement,
+      epoch: Cardano.EpochNo(500),
+      poolId: Cardano.PoolId('pool1y6chk7x7fup4ms9leesdr57r4qy9cwxuee0msan72x976a6u0nc')
+    }
+  ],
+  fee: 10n,
+  inputs: [],
+  outputs: [txOut]
+};
+
+export const noInputsCbor = HexBlob(
+  'a30181825839009493315cd92eb5d8c4304e67b7e16ae36d61d34502694657811a2c8e32c728d3861e164cab28cb8f006448139c8f1740ffb8e7aa9e5232dc820aa3581c2a286ad895d091f2b3d168a6091ad2627d30a72761a5bc36eef00740a14014581c659f2917fb63f12b33667463ee575eeac1845bbc736b9c0bbc40ba82a14454534c411832581c7eae28af2208be856f7a119668ae52a49b73725e326dc16579dcc373a240182846504154415445181e020a04818304581c26b17b78de4f035dc0bfce60d1d3c3a8085c38dcce5fb8767e518bed1901f4'
+);
+
 export const conwayCore: Cardano.TxBody = {
   ...core,
   donation: 1000n,
@@ -239,4 +256,12 @@ describe('TransactionBody', () => {
 
     expect(withdrawals).toEqual(expectedWithdrawals);
   });
+
+  it('can encode transaction bodies with 0 inputs correctly', () => {
+    const bodyFromCbor = TransactionBody.fromCbor(noInputsCbor);
+    const bodyFromCore = TransactionBody.fromCore(noInputsCore);
+
+    expect(bodyFromCbor.toCore()).toEqual(noInputsCore);
+    expect(bodyFromCore.toCbor()).toEqual(noInputsCbor);
+  });
 });