fix: upgrade github workflow vercel deploy #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cardano-documentation ready! ✅ Preview Built with commit d2fe881. |
ianhanssoniohk
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An outdated version of
amondnet/vercel-actionwas causing the GitHub Workflow Vercel deploys to fail. Most likely from the Node.js 16 actions being deprecated.Upgrading the version fixed the issue and Vercel deploys finished successfully.
UPDATE
The issue with the Vercel deploy fail was actually because the branch was from a fork of the
cardano-documentationrepo and so does not have access to this repo's secrets. The triggered workflow runs in the context of the fork repo aspull_requestevents are used rather thanpull_request_targetIt's good to keep dependancies up to date though!