feat: allow external cardano-wallet (tls) and cardano-db-sync

[womfoo]

Overview

Screenshots

Checklists

Pre-submit checklist:

• Self-reviewed the diff
• New code has proper comments/documentation/tests
• Any changes not covered by tests have been tested manually
• The README files are updated
• If new libraries are included, they have licenses compatible with our project
• If there is a db migration altering existing tables, there is a proper migration test

Pre-merge checklist:

• Commits have useful messages
• Review clarifications made it into the code

[github-actions]

Unit Test Results

289 tests  ±0   288 ✔️ ±0   23s ⏱️ -1s
  36 suites ±0       1 💤 ±0 
  36 files   ±0       0 ❌ ±0 

Results for commit 0ccfa70. ± Comparison against base commit 94a31c5.

♻️ This comment has been updated with latest results.

[atala-dev]

🦙 MegaLinter status: ❌ ERROR

Descriptor	Linter	Files	Fixed	Errors
✅ REPOSITORY	dustilock	yes		no
✅ REPOSITORY	git_diff	yes		no
❌ REPOSITORY	grype	yes		1
⚠️ REPOSITORY	kics	yes		47
✅ REPOSITORY	syft	yes		no
✅ REPOSITORY	trivy-sbom	yes		no
⚠️ REPOSITORY	trufflehog	yes		1

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[yshyn-iohk]

looks good, but I cannot test it by reading ;)

[womfoo]

Adding diffs from
values config:

$ diff -u before-values.yaml after-values.yaml
--- before-values.yaml
+++ after-values.yaml
@@ -2,12 +2,13 @@
   enabled: true
   applicationUrls:
   - legacy-preprod.atalaprism.io
   platformIngressUrl: internal-useast1-sjd4e.atalaprism.io
   consumers: ["key1"]
 secrets:
   secretStore: prism-v2-dev-sjd4e-us-east-1-externalsecrets
   dockerRegistryToken: dev-sjd4e-argocd-github-docker-registry-token
+  cardanoWallet: dev-sjd4e-demeter-preprod-v14-wallet
+  cardanoDbSync: dev-sjd4e-demeter-preprod-v14-dbsync
 server:
   image:
     version: "v1.4.0"
@@ -17,6 +18,9 @@
     AUTH_ENABLED: true
     AUTH_TOKENS: c0aXYu6PaLqGtZUuzeoc6wLETf74wjlKqixjM
 vdr:
-  cardanoNamespace: cardano-stack
-  cardanoWallet: dev-sjd4e-cardano-wallet
-  cardanoNode: atala-cardano-dev-sjd4e-preprod
+  externalResources:
+    db_sync:
+      host: dbsync-v3.demeter.run
+      database: dbsync-preprod
+    wallet:
+      host: 8090-cardano-wallet-preprod-bdj2f7.workloads-m1.demeter.run

and rendered helm:

$ diff -u before-helm.yaml after-helm.yaml
--- before-helm.yaml
+++ after-helm.yaml
+---                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               20:29:57 [41/987]
+# Source: prism-node/templates/configmap-nginx.yaml
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: wallet-nginx-proxy
+data:
+  server-block.conf: |
+    server {
+      listen 8080;
+      location / {
+        resolver 8.8.8.8;
+        proxy_pass https://8090-cardano-wallet-preprod-bdj2f7.workloads-m1.demeter.run$uri$is_args$args;
+      }
+    }
@@ -371,43 +386,39 @@
           - name: NODE_CARDANO_CONFIRMATION_BLOCKS
             value: "1"
           - name: NODE_CARDANO_WALLET_API_HOST
-            value: "atala-cardano-dev-sjd4e-preprod.cardano-stack"
+            value: "legacy-prism-preprod-wallet"
           - name: NODE_CARDANO_WALLET_ID
             valueFrom:
               secretKeyRef:
-                name: "atala-cardano-dev-sjd4e-preprod-dev-sjd4e-cardano-wallet"
-                key: wallet_id
+                name: "dev-sjd4e-demeter-preprod-v14-wallet"
+                key: id
                 optional: false
           - name: NODE_CARDANO_WALLET_PASSPHRASE
             valueFrom:
               secretKeyRef:
-                name: "atala-cardano-dev-sjd4e-preprod-dev-sjd4e-cardano-wallet"
+                name: "dev-sjd4e-demeter-preprod-v14-wallet"
                 key: passphrase
                 optional: false
           - name: NODE_CARDANO_WALLET_API_PORT
-            value: "8090"
+            value: "80"
           - name: NODE_CARDANO_PAYMENT_ADDRESS
-            valueFrom:
-              secretKeyRef:
-                name: "atala-cardano-dev-sjd4e-preprod-dev-sjd4e-cardano-wallet"
-                key: address
-                optional: false
+            value: ""
           - name: NODE_CARDANO_DB_SYNC_USERNAME
             valueFrom:
               secretKeyRef:
-                name: "legacy-prism-preprod.cardano.atala-cardano-dev-sjd4e-preprod-postgres-cluster.credentials.postgresql.acid.zalan.do"
+                name: "dev-sjd4e-demeter-preprod-v14-dbsync"
                 key: username
                 optional: false
           - name: NODE_CARDANO_DB_SYNC_PASSWORD
             valueFrom:
               secretKeyRef:
-                name: "legacy-prism-preprod.cardano.atala-cardano-dev-sjd4e-preprod-postgres-cluster.credentials.postgresql.acid.zalan.do"
+                name: "dev-sjd4e-demeter-preprod-v14-dbsync"
                 key: password
                 optional: false
           - name: NODE_CARDANO_DB_SYNC_DATABASE
-            value: "cardano"
+            value: "dbsync-preprod"
           - name: NODE_CARDANO_DB_SYNC_HOST
-            value: "atala-cardano-dev-sjd4e-preprod-postgres-cluster.cardano-stack"
+            value: "dbsync-v3.demeter.run"
           # Prism Node Variables
           - name: NODE_PSQL_USERNAME
             valueFrom:
@@ -546,6 +554,57 @@
     - extract:
         key: dev-sjd4e-argocd-github-docker-registry-token
 ---
+# Source: prism-node/templates/externalsecret.yaml
+apiVersion: external-secrets.io/v1beta1
+kind: ExternalSecret
+metadata:
+  name: "atala-cardano-dev-preprod-dev-k8s-cardano-wallet"
+  namespace: legacy-prism-preprod
+  labels:
+      app.kubernetes.io/part-of: prism-node
+spec:
+  refreshInterval: "0"
+  secretStoreRef:
+    name: prism-v2-dev-sjd4e-us-east-1-externalsecrets
+    kind: ClusterSecretStore
+  dataFrom:
+    - extract:
+        key: dev-k8s-cardano-wallet
+---
+# Source: prism-node/templates/externalsecret.yaml
+apiVersion: external-secrets.io/v1beta1
+kind: ExternalSecret
+metadata:
+  name: "dev-sjd4e-demeter-preprod-v14-wallet"
+  namespace: legacy-prism-preprod
+  labels:
+      app.kubernetes.io/part-of: prism-node
+spec:
+  refreshInterval: "0"
+  secretStoreRef:
+    name: prism-v2-dev-sjd4e-us-east-1-externalsecrets
+    kind: ClusterSecretStore
+  dataFrom:
+    - extract:
+        key: "dev-sjd4e-demeter-preprod-v14-wallet"
+---
+# Source: prism-node/templates/externalsecret.yaml
+apiVersion: external-secrets.io/v1beta1
+kind: ExternalSecret
+metadata:
+  name: "dev-sjd4e-demeter-preprod-v14-dbsync"
+  namespace: legacy-prism-preprod
+  labels:
+      app.kubernetes.io/part-of: prism-node
+spec:
+  refreshInterval: "0"
+  secretStoreRef:
+    name: prism-v2-dev-sjd4e-us-east-1-externalsecrets
+    kind: ClusterSecretStore
+  dataFrom:
+    - extract:
+        key: "dev-sjd4e-demeter-preprod-v14-dbsync"
+---
 # Source: prism-node/templates/postgresql.yaml
 apiVersion: "acid.zalan.do/v1"
 kind: postgresql

[Dale-iohk]

Checkmarx One – Scan Summary & Details – 1be8597d-ce06-442b-aa7d-cfd0ac8fff5e

Fixed Issues

Severity	Issue	Source File / Package
	Secrets As Environment Variables	/deployment.yaml: [39](https://github.com/input-output-hk/atala-prism/blob/external-cardano-wallet-db-sync//infrastructure/charts/node/templates/deployment.yaml# L39)
	Secrets As Environment Variables	/deployment.yaml: [39](https://github.com/input-output-hk/atala-prism/blob/external-cardano-wallet-db-sync//infrastructure/charts/node/templates/deployment.yaml# L39)
	Secrets As Environment Variables	/deployment.yaml: [39](https://github.com/input-output-hk/atala-prism/blob/external-cardano-wallet-db-sync//infrastructure/charts/node/templates/deployment.yaml# L39)