Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: current regex does not supports multiple services within a DID #8

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: current regex does not supports multiple services within a DID #8

merged 1 commit into from
Nov 24, 2023

Conversation

cristianIOHK
Copy link
Contributor

Overview

Current regex does not supports multiple services within a DID

Fixes #

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@hamada147 hamada147 added the bug Something isn't working label Nov 24, 2023
@atala-dev
Copy link
Contributor

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 1.89s
✅ EDITORCONFIG editorconfig-checker 56 0 0.16s
✅ JSON eslint-plugin-jsonc 1 0 4.11s
✅ JSON jsonlint 1 0 0.23s
⚠️ JSON prettier 1 1 0.83s
✅ JSON v8r 1 0 2.22s
✅ KOTLIN ktlint 26 0 46.83s
⚠️ MARKDOWN markdownlint 6 86 1.03s
✅ MARKDOWN markdown-table-formatter 6 0 1.71s
✅ REPOSITORY devskim yes no 1.5s
✅ REPOSITORY dustilock yes no 0.03s
✅ REPOSITORY gitleaks yes no 0.24s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY grype yes no 17.63s
✅ REPOSITORY secretlint yes no 0.81s
✅ REPOSITORY syft yes no 0.32s
✅ REPOSITORY trivy yes no 3.72s
✅ REPOSITORY trivy-sbom yes no 0.99s
✅ XML xmllint 2 0 0.01s
⚠️ YAML prettier 7 1 0.46s
✅ YAML v8r 7 0 5.39s
✅ YAML yamllint 7 0 0.44s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@cristianIOHK cristianIOHK merged commit 8f7636c into main Nov 24, 2023
3 checks passed
@cristianIOHK cristianIOHK deleted the fix/mediator_did_multiserivce branch November 24, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristianIOHK @atala-dev @hamada147