-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update peer-did creation and resolution inline with … #14
feat: Update peer-did creation and resolution inline with … #14
Conversation
…peer-did spec Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Unit Test Results96 tests 96 ✅ 1s ⏱️ Results for commit 51122cf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming there are no logical changes that the work done by @mineme0110 to fix the other lib)
@@ -130,53 +130,152 @@ Example of DID documents: | |||
"id": "did:peer:0z6MkqRYqQiSgvZQdnBytw86Qbs2ZWUkGv22od935YF4s8M7V", | |||
"authentication": [ | |||
{ | |||
"id": "did:peer:0z6MkqRYqQiSgvZQdnBytw86Qbs2ZWUkGv22od935YF4s8M7V#6MkqRYqQiSgvZQdnBytw86Qbs2ZWUkGv22od935YF4s8M7V", | |||
"id": "did:peer:0z6MkqRYqQiSgvZQdnBytw86Qbs2ZWUkGv22od935YF4s8M7V#", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"id": "did:peer:0z6MkqRYqQiSgvZQdnBytw86Qbs2ZWUkGv22od935YF4s8M7V#", | |
"id": "did:peer:0z6MkqRYqQiSgvZQdnBytw86Qbs2ZWUkGv22od935YF4s8M7V#key-1", |
Can we merge this? |
…nline with … (#14) Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
# [1.1.0](v1.0.0...v1.1.0) (2024-02-06) ### Features * Update peer-did creation and resolution inline with … ([#14](#14)) ([cb52a8d](cb52a8d))
# [1.1.0](v1.0.0...v1.1.0) (2024-02-06) ### Features * Update peer-did creation and resolution inline with … ([#14](#14)) ([cb52a8d](cb52a8d))
Overview
https://identity.foundation/peer-did-method-spec
This PR updates the library to align with the latest specifications for creating and resolving peer DIDs. It ensures compatibility with current and new methods of specifying the service field in a peer DID.
The PR accommodates two formats for defining the service field in the peer DID creation process. The first format is as follows:
Using this format, a peer DID similar to the one below is created:
The second format, as per the new peer DID spec, is as follows:
This results in a peer DID like this:
In both cases, the resolution of the peer DID will conform to the new peer DID specification, producing a resolved DID document similar to the following:
Tests have been added and updated to support both described cases, ensuring that the peer DID creation and resolution process aligns with the new peer DID specification.
Fixes #
Checklist
My PR contains...
My changes...
Documentation
Tests