refactor: refactor event_filter #4788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
wischoepke
force-pushed
the
refactor/event-filter-parsing-methods
branch
from
2d47db8 to
02ba3c2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
with a smaller generic solution to decrease event filter complexity * remove unused parameter.
unmarshaller
and additional implementations * try to simplify event_filter methods (some methods are redundant and can be removed for example filter or better updating votes per note), * move some business (board, vote etc) specific structs and methods to new folder structure (vote specific stuff to vote), * introduce technical helpers (should be only small methods) for unmarshal event data, * reduce complexity of event_filter. use a switch case structure with small blocks to call the specific methods. every method returns a status in the form of true/false if the event is successful proceeded or not, * every method have nearly the same structure now ( easier to read and more maintainable now) * encapsulate logic in business specific services (board, notes, votes etc), * try to add some new unit tests, * implement some helper methods like map and filter and add tests for them.
wischoepke
force-pushed
the
refactor/event-filter-parsing-methods
branch
from
d9c7bbf to
e72b9a5
Compare
This comment has been minimized.
This comment has been minimized.
wischoepke
changed the title
This comment has been minimized.
This comment has been minimized.
* rename methode to make the name more specific in compare to library map methods
|
The deployment to the dev cluster was successful. You can find the deployment here: https://4788.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 14/14 successful.
commit sha: abde6be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Event filter parsing methods refactored into a more generic solution. A small step to reduce the complexity of the event filter and improve testability.
Checklist
(Optional) Visual Changes
No visual changes. Just a small refactoring