fixed tests

inovex · Jan 15, 2025 · a2f1f65 · a2f1f65
1 parent 29d4e70
commit a2f1f65
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 15 deletions.
diff --git a/src/components/Column/__tests__/__snapshots__/Column.test.tsx.snap b/src/components/Column/__tests__/__snapshots__/Column.test.tsx.snap
@@ -570,8 +570,10 @@ exports[`Column should have correct style show column with correct style 1`] = `
                   role="none"
                 >
                   <button
+                    aria-label="Remove vote"
                     class="dot-button vote-button-remove"
-                    title="Remove vote"
+                    data-tooltip-content="Remove vote"
+                    data-tooltip-id="scrumlr-tooltip"
                   >
                     <span
                       class="vote-button-remove__folded-corner"
@@ -588,9 +590,11 @@ exports[`Column should have correct style show column with correct style 1`] = `
                     </span>
                   </button>
                   <button
+                    aria-label="Multiple votes are not allowed"
                     class="dot-button vote-button-add"
+                    data-tooltip-content="Multiple votes are not allowed"
+                    data-tooltip-id="scrumlr-tooltip"
                     disabled=""
-                    title="Add vote"
                   >
                     <svg
                       class="vote-button-add__icon"
@@ -1151,8 +1155,10 @@ exports[`Column should have correct style show column with correct style 1`] = `
                   role="none"
                 >
                   <button
+                    aria-label="Add vote"
                     class="dot-button vote-button-add"
-                    title="Add vote"
+                    data-tooltip-content="Add vote"
+                    data-tooltip-id="scrumlr-tooltip"
                   >
                     <svg
                       class="vote-button-add__icon"

diff --git a/src/components/DotButton/DotButton.tsx b/src/components/DotButton/DotButton.tsx
@@ -6,7 +6,6 @@ type DotButtonProps = {
   className?: string;
   disabled?: boolean;
   onClick?: () => void;
-  title?: string;
   onAnimationEnd?: () => void;
   dataTooltipId?: string;
   dataTooltipContent?: string;
@@ -20,7 +19,7 @@ export const DotButton: FC<PropsWithChildren<DotButtonProps>> = (props) => (
       e.stopPropagation();
       props.onClick?.();
     }}
-    title={props.title}
+    aria-label={props.dataTooltipContent}
     onAnimationEnd={props.onAnimationEnd}
     data-tooltip-id={props.dataTooltipId}
     data-tooltip-content={props.dataTooltipContent}

diff --git a/src/components/Votes/__tests__/Votes.test.tsx b/src/components/Votes/__tests__/Votes.test.tsx
@@ -90,8 +90,8 @@ describe("Votes", () => {
 
     expect(screen.queryByTitle(i18n.t("Votes.AddVote"))).not.toBeInTheDocument();
     expect(screen.queryByTitle(i18n.t("Votes.RemoveVote"))).not.toBeInTheDocument();
-    expect(screen.queryByTitle(i18n.t("Votes.VotesOnNote", {votes: 1}))).toBeInTheDocument();
-    expect(screen.queryByTitle(i18n.t("Votes.VotesOnNote", {votes: 1}))).toBeDisabled();
+    expect(screen.queryByLabelText(i18n.t("Votes.VotesOnNote", {count: 1}))).toBeInTheDocument();
+    expect(screen.queryByLabelText(i18n.t("Votes.VotesOnNote", {count: 1}))).toBeDisabled();
   });
 
   it("add vote button should be visible and remove vote button not disabled on locked board if participant is moderator", () => {
@@ -115,12 +115,16 @@ describe("Votes", () => {
           others: [],
           focusInitiator: undefined,
         },
+        votings: {
+          open: getTestVoting({allowMultipleVotes: true}),
+          past: [],
+        },
       })
     );
 
-    expect(screen.getByTitle(i18n.t("Votes.AddVote"))).toBeInTheDocument();
-    expect(screen.queryByTitle(i18n.t("Votes.RemoveVote"))).toBeInTheDocument();
-    expect(screen.queryByTitle(i18n.t("Votes.RemoveVote"))).not.toBeDisabled();
-    expect(screen.queryByTitle(i18n.t("Votes.VotesOnNote", {votes: 1}))).not.toBeInTheDocument();
+    expect(screen.getByLabelText(i18n.t("Votes.AddVote"))).toBeInTheDocument();
+    expect(screen.getByLabelText(i18n.t("Votes.RemoveVote"))).toBeInTheDocument();
+    expect(screen.getByLabelText(i18n.t("Votes.RemoveVote"))).not.toBeDisabled();
+    expect(screen.queryByLabelText(i18n.t("Votes.VotesOnNote", {count: 1}))).not.toBeInTheDocument();
   });
 });
diff --git a/src/components/Votes/__tests__/__snapshots__/Votes.test.tsx.snap b/src/components/Votes/__tests__/__snapshots__/Votes.test.tsx.snap
@@ -7,8 +7,10 @@ exports[`Votes should render correctly with no votes and active voting 1`] = `
     role="none"
   >
     <button
+      aria-label="Add vote"
       class="dot-button vote-button-add"
-      title="Add vote"
+      data-tooltip-content="Add vote"
+      data-tooltip-id="scrumlr-tooltip"
     >
       <svg
         class="vote-button-add__icon"
@@ -29,8 +31,10 @@ exports[`Votes should render correctly with votes and active voting 1`] = `
     role="none"
   >
     <button
+      aria-label="Remove vote"
       class="dot-button vote-button-remove"
-      title="Remove vote"
+      data-tooltip-content="Remove vote"
+      data-tooltip-id="scrumlr-tooltip"
     >
       <span
         class="vote-button-remove__folded-corner"
@@ -47,9 +51,11 @@ exports[`Votes should render correctly with votes and active voting 1`] = `
       </span>
     </button>
     <button
+      aria-label="Multiple votes are not allowed"
       class="dot-button vote-button-add"
+      data-tooltip-content="Multiple votes are not allowed"
+      data-tooltip-id="scrumlr-tooltip"
       disabled=""
-      title="Add vote"
     >
       <svg
         class="vote-button-add__icon"
@@ -68,9 +74,11 @@ exports[`Votes should render correctly with votes and disabled voting 1`] = `
     role="none"
   >
     <button
+      aria-label="1 vote"
       class="dot-button vote-button-remove"
+      data-tooltip-content="1 vote"
+      data-tooltip-id="scrumlr-tooltip"
       disabled=""
-      title="1 vote(s)"
     >
       <span
         class="vote-button-remove__folded-corner"