Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for all-day events #218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Small fixes for all-day events #218

wants to merge 2 commits into from

Conversation

timonegk
Copy link
Collaborator

This PR introduces some fixes for all-day events:

  • the TimeFrame filter should not filter all-day events because if it does, there is no way to filter for business hours but keep the all-day events.
  • for all-day events, only the dates should be compared, not the time. The reason for this change is that all-day events in zep start and end at 00:00 local time zone, whereas all-day events in google start and end at 00:00 UTC. Therefore, the event is always shown as "changed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxndr13 alxndr13 alxndr13 approved these changes

@MichaelEischer MichaelEischer Awaiting requested review from MichaelEischer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timonegk @alxndr13