Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release process #197

Merged
merged 9 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/inngest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ jobs:
working-directory: "./pkg/inngest"
- name: "Upload package to PyPI"
uses: "pypa/gh-action-pypi-publish@release/v1"
with:
packages-dir: "./pkg/inngest/dist"

type-check:
runs-on: "ubuntu-latest"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/inngest_encryption.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ jobs:
working-directory: "./pkg/inngest_encryption"
- name: "Upload package to PyPI"
uses: "pypa/gh-action-pypi-publish@release/v1"
with:
packages-dir: "./pkg/inngest_encryption/dist"

type-check:
runs-on: "ubuntu-latest"
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ DEV_SERVER_VERBOSE=1

# Publish

Change the package version in `pyproject.toml` and `const.py`.
Change the package version in the package's `pyproject.toml` (e.g. `pkg/inngest/pyproject.toml`).

Create and push a git tag that matches the package version. For example, the following command tags and releases version `1.2.3`:
Set the `VERSION` env var and run the `release` make target for the package. For example, the following command releases version `1.2.3` of the `inngest` package:

```sh
(export TAG=1.2.3 && git tag $TAG && git push origin $TAG)
(cd pkg/inngest && export VERSION=1.2.3 && make release)
```

This will start CI for the tag, including publishing to PyPI.
Expand Down
206 changes: 0 additions & 206 deletions README.md

This file was deleted.

1 change: 1 addition & 0 deletions README.md
2 changes: 1 addition & 1 deletion pkg/inngest/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ lint: check-venv
@ruff check .

release:
@grep "version = \"$${VERSION}\"" pyproject.toml && git tag $${VERSION} && git push origin $${VERSION} || echo "pyproject.toml version does not match"
@grep "version = \"$${VERSION}\"" pyproject.toml && git tag inngest@$${VERSION} && git push origin inngest@$${VERSION} || echo "pyproject.toml version does not match"

.PHONY: type-check
type-check: check-venv
Expand Down
Loading