Add workaround for bug in pythonExtension.getExecutionDetails() method #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloLey
reviewed
Dec 12, 2023
| @@ -40,7 +40,7 @@ async function main() { | |||
|
|
|||
| const vscodeExecutablePath = await downloadAndUnzipVSCode('stable'); | |||
| const cliPath = resolveCliPathFromVSCodeExecutablePath(vscodeExecutablePath, "linux-x64"); | |||
| cp.spawnSync(cliPath, ['--install-extension', 'ms-python.python'], { | |||
| cp.spawnSync(cliPath, ['--install-extension', 'ms-python.python', '--force'], { | |||
There was a problem hiding this comment.
It doesn't work without this anymore?
There was a problem hiding this comment.
This flag makes sure that we always check whether there is a newer version of the extensions available and upgrade to it if there is one. It should just make sure that we get faster feedback when there is a breaking change. So to answer your question: without this flag the tests should also work.
FloLey
approved these changes
Dec 12, 2023
Hugo-Inmanta
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug in the Python extension causes the
this.pythonApi.settings.getExecutionDetails().execCommand[0]to return the path to the root of the venv instead of the path to the python binary in that venv. This PR applies a workaround for this issue until it's fix in the python extension.Closes #1508